Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 2326613003: [Extensions] Validate Profile extistence in ActivityLog reporting (Closed)

Created:
4 years, 3 months ago by Devlin
Modified:
4 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, felt, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] Validate Profile extistence in ActivityLog reporting We report events to the activity log on the UI thread, which can involve a thread hop. During this thread hop, it's possible the profile was invalidated. Check the profile before using it. BUG=643012 Committed: https://crrev.com/fdae1ec9baa35c06de65e8b823336c5772e7060e Cr-Commit-Position: refs/heads/master@{#417581}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M chrome/browser/extensions/activity_log/activity_log.cc View 3 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Devlin
Antony, can you take a look?
4 years, 3 months ago (2016-09-08 19:16:32 UTC) #7
asargent_no_longer_on_chrome
lgtm
4 years, 3 months ago (2016-09-09 04:41:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2326613003/1
4 years, 3 months ago (2016-09-09 14:25:50 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-09 14:29:35 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 14:31:27 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fdae1ec9baa35c06de65e8b823336c5772e7060e
Cr-Commit-Position: refs/heads/master@{#417581}

Powered by Google App Engine
This is Rietveld 408576698