Revert of GPU driver bug list: remove the use program after link workaround

Revert of GPU driver bug list: remove the use program after link workaround (patchset #2 id:20001 of https://codereview.chromium.org/2326713002/ )

Reason for revert:
Potential regression https://bugs.chromium.org/p/chromium/issues/detail?id=645498

Original issue's description:
> GPU driver bug list: remove the use program after link workaround
>
> The origins of this workaround go waaaaay in the past and seem to
> contradict themselves (only OSX, vs. not OSX)
>
> BUG=590870
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
>
> Committed: https://crrev.com/5d79fa21a0e1536b439584a8bce1f17fbc0c22b6
> Cr-Commit-Position: refs/heads/master@{#417397}

TBR=zmo@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=590870
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/ed7c9c148e43cb09bcef26c131bd445a1d0be078
Cr-Commit-Position: refs/heads/master@{#417930}

[Corentin Wallez, 2016-09-09 17:15:31]

The CQ bit was checked by cwallez@chromium.org

[Corentin Wallez, 2016-09-09 17:15:31]

Created Revert of GPU driver bug list: remove the use program after link
workaround

[commit-bot: I haz the power, 2016-09-09 17:15:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 17:16:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-09 17:16:22]

Failed to apply patch for gpu/config/gpu_driver_bug_list_json.cc:
While running git apply --index -3 -p1;
  error: patch failed: gpu/config/gpu_driver_bug_list_json.cc:19
  Falling back to three-way merge...
  Applied patch to 'gpu/config/gpu_driver_bug_list_json.cc' with conflicts.
  U gpu/config/gpu_driver_bug_list_json.cc

Patch:       gpu/config/gpu_driver_bug_list_json.cc
Index: gpu/config/gpu_driver_bug_list_json.cc
diff --git a/gpu/config/gpu_driver_bug_list_json.cc
b/gpu/config/gpu_driver_bug_list_json.cc
index
b06b11a7daf7b937987d66212cb023e6f0921626..29c95f404a61e489f493cf50743e907064ad8697
100644
--- a/gpu/config/gpu_driver_bug_list_json.cc
+++ b/gpu/config/gpu_driver_bug_list_json.cc
@@ -19,7 +19,7 @@
 {
   "name": "gpu driver bug list",
   // Please update the version number whenever you change this file.
-  "version": "8.95",
+  "version": "8.94",
   "entries": [
     {
       "id": 1,
@@ -41,6 +41,26 @@
       "gl_vendor": "ARM.*",
       "features": [
         "use_client_side_arrays_for_stream_buffers"
+      ]
+    },
+    {
+      "id": 5,
+      "description": "Always call glUseProgram after a successful link to avoid
a driver bug",
+      "cr_bugs": [349137],
+      "vendor_id": "0x10de",
+      "exceptions": [
+        {
+          "os": {
+            "type": "macosx",
+            "version": {
+              "op": ">=",
+              "value": "10.9"
+            }
+          }
+        }
+      ],
+      "features": [
+        "use_current_program_after_successful_link"
       ]
     },
     {

[Corentin Wallez, 2016-09-12 13:44:46]

The CQ bit was checked by cwallez@chromium.org

[Corentin Wallez, 2016-09-12 13:44:51]

The CQ bit was unchecked by cwallez@chromium.org

[Corentin Wallez, 2016-09-12 13:46:42]

Description was changed from

==========
Revert of GPU driver bug list: remove the use program after link workaround
(patchset #2 id:20001 of https://codereview.chromium.org/2326713002/ )

Reason for revert:
Potential regression
https://bugs.chromium.org/p/chromium/issues/detail?id=645498

Original issue's description:
> GPU driver bug list: remove the use program after link workaround
> 
> The origins of this workaround go waaaaay in the past and seem to
> contradict themselves (only OSX, vs. not OSX)
> 
> BUG=590870
>
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> 
> Committed: https://crrev.com/5d79fa21a0e1536b439584a8bce1f17fbc0c22b6
> Cr-Commit-Position: refs/heads/master@{#417397}

TBR=zmo@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=590870
==========

to

==========
Revert of GPU driver bug list: remove the use program after link workaround
(patchset #2 id:20001 of https://codereview.chromium.org/2326713002/ )

Reason for revert:
Potential regression
https://bugs.chromium.org/p/chromium/issues/detail?id=645498

Original issue's description:
> GPU driver bug list: remove the use program after link workaround
> 
> The origins of this workaround go waaaaay in the past and seem to
> contradict themselves (only OSX, vs. not OSX)
> 
> BUG=590870
>
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> 
> Committed: https://crrev.com/5d79fa21a0e1536b439584a8bce1f17fbc0c22b6
> Cr-Commit-Position: refs/heads/master@{#417397}

TBR=zmo@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=590870
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Corentin Wallez, 2016-09-12 13:46:52]

The CQ bit was checked by cwallez@chromium.org

[commit-bot: I haz the power, 2016-09-12 13:47:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-12 13:48:56]

Committed patchset #2 (id:100001)

[commit-bot: I haz the power, 2016-09-12 13:50:55]

Description was changed from

==========
Revert of GPU driver bug list: remove the use program after link workaround
(patchset #2 id:20001 of https://codereview.chromium.org/2326713002/ )

Reason for revert:
Potential regression
https://bugs.chromium.org/p/chromium/issues/detail?id=645498

Original issue's description:
> GPU driver bug list: remove the use program after link workaround
> 
> The origins of this workaround go waaaaay in the past and seem to
> contradict themselves (only OSX, vs. not OSX)
> 
> BUG=590870
>
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> 
> Committed: https://crrev.com/5d79fa21a0e1536b439584a8bce1f17fbc0c22b6
> Cr-Commit-Position: refs/heads/master@{#417397}

TBR=zmo@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=590870
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Revert of GPU driver bug list: remove the use program after link workaround
(patchset #2 id:20001 of https://codereview.chromium.org/2326713002/ )

Reason for revert:
Potential regression
https://bugs.chromium.org/p/chromium/issues/detail?id=645498

Original issue's description:
> GPU driver bug list: remove the use program after link workaround
>
> The origins of this workaround go waaaaay in the past and seem to
> contradict themselves (only OSX, vs. not OSX)
>
> BUG=590870
>
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
>
> Committed: https://crrev.com/5d79fa21a0e1536b439584a8bce1f17fbc0c22b6
> Cr-Commit-Position: refs/heads/master@{#417397}

TBR=zmo@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=590870
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/ed7c9c148e43cb09bcef26c131bd445a1d0be078
Cr-Commit-Position: refs/heads/master@{#417930}
==========

[commit-bot: I haz the power, 2016-09-12 13:50:56]

Patchset 2 (id:??) landed as
https://crrev.com/ed7c9c148e43cb09bcef26c131bd445a1d0be078
Cr-Commit-Position: refs/heads/master@{#417930}

[Zhenyao Mo, 2016-09-12 18:09:52]

On 2016/09/12 13:50:56, commit-bot: I haz the power wrote:
> Patchset 2 (id:??) landed as
> https://crrev.com/ed7c9c148e43cb09bcef26c131bd445a1d0be078
> Cr-Commit-Position: refs/heads/master@{#417930}

This is unfortunately.  Are we able to confirm this is the culprit?

[Corentin Wallez, 2016-09-12 18:17:03]

On 2016/09/12 at 18:09:52, zmo wrote:
> On 2016/09/12 13:50:56, commit-bot: I haz the power wrote:
> > Patchset 2 (id:??) landed as
> > https://crrev.com/ed7c9c148e43cb09bcef26c131bd445a1d0be078
> > Cr-Commit-Position: refs/heads/master@{#417930}
> 
> This is unfortunately.  Are we able to confirm this is the culprit?

I'm 95% confident this was not the CL's fault, but given how puzzling the
failure on the jelly bean bot, I think it is worth trying a revert. I'll wait
until tomorrow, see if the bots goes green and re-revert if it doesn't.

[Corentin Wallez, 2016-09-13 14:01:39]

On 2016/09/12 at 18:17:03, Corentin Wallez wrote:
> On 2016/09/12 at 18:09:52, zmo wrote:
> > On 2016/09/12 13:50:56, commit-bot: I haz the power wrote:
> > > Patchset 2 (id:??) landed as
> > > https://crrev.com/ed7c9c148e43cb09bcef26c131bd445a1d0be078
> > > Cr-Commit-Position: refs/heads/master@{#417930}
> > 
> > This is unfortunately.  Are we able to confirm this is the culprit?
> 
> I'm 95% confident this was not the CL's fault, but given how puzzling the
failure on the jelly bean bot, I think it is worth trying a revert. I'll wait
until tomorrow, see if the bots goes green and re-revert if it doesn't.

Revert didn't help, unreverting.

[Corentin Wallez, 2016-09-13 14:01:54]

A revert of this CL (patchset #2 id:100001) has been created in
https://codereview.chromium.org/2334203002/ by cwallez@chromium.org.

The reason for reverting is: Revert didn't help..