Adding a Confirmation dialog for It2Me on Windows

Adding a Confirmation dialog for It2Me on Windows

This change adds a confirmation dialog for Windows for the It2Me host.  I've
also added placeholder files for the other platforms (beyond ChromeOS).  This
dialog is displayed when the remote user begins the connection process and
shows the email address of the remote user and gives the local user a chance to
accept/reject the connection.

BUG=645540
Committed: https://crrev.com/7cc2c86157e6a02a575ea610339983273de38b85
Cr-Commit-Position: refs/heads/master@{#418261}

[joedow, 2016-09-09 03:25:41]

The CQ bit was checked by joedow@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-09 03:26:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 03:42:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-09 03:42:39]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[joedow, 2016-09-09 16:28:17]

The CQ bit was checked by joedow@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-09 16:28:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 16:40:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-09 16:40:22]

Dry run: Try jobs failed on following builders:
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)

[joedow, 2016-09-10 02:53:48]

Description was changed from

==========
Adding a Confirmation dialog for It2Me on Windows

This change adds a confirmation dialog for Windows for the It2Me host.  I've
also added placeholder files for the other platforms (beyond ChromeOS).  This
dialog is displayed when the remote user begins the connection process and
shows the email address of the remote user and gives the local user a chance to
accept/reject the connection.

BUG=617185
==========

to

==========
Adding a Confirmation dialog for It2Me on Windows

This change adds a confirmation dialog for Windows for the It2Me host.  I've
also added placeholder files for the other platforms (beyond ChromeOS).  This
dialog is displayed when the remote user begins the connection process and
shows the email address of the remote user and gives the local user a chance to
accept/reject the connection.

BUG=645540
==========

[joedow, 2016-09-10 03:01:34]

The CQ bit was checked by joedow@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-10 03:01:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-10 04:13:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-10 04:13:27]

Dry run: This issue passed the CQ dry run.

[joedow, 2016-09-12 16:42:46]

Patchset #2 (id:20001) has been deleted

[joedow, 2016-09-12 17:32:58]

The CQ bit was checked by joedow@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-12 17:33:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-12 18:49:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-12 18:49:51]

Dry run: This issue passed the CQ dry run.

[joedow, 2016-09-12 19:27:50]

joedow@chromium.org changed reviewers:
+ sergeyu@chromium.org

[joedow, 2016-09-12 19:27:51]

PTAL!

[joedow, 2016-09-12 19:27:57]

The CQ bit was checked by joedow@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-12 19:28:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-12 20:41:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-12 20:41:55]

Dry run: This issue passed the CQ dry run.

[Sergey Ulanov, 2016-09-13 00:13:56]

lgtm

https://codereview.chromium.org/2326553003/diff/80001/remoting/host/it2me/it2...
File remoting/host/it2me/it2me_confirmation_dialog_win.cc (right):

https://codereview.chromium.org/2326553003/diff/80001/remoting/host/it2me/it2...
remoting/host/it2me/it2me_confirmation_dialog_win.cc:28: const int
kDialogTimeoutMS = 60 * 1000;
TimeDelta constructor is declared as constexpr now, so we can use it for
constants:

constexpr base::TimeDelta kDialogTimeout = base::TimeDelta::FromMinutes(1).

If you keep it as int then please use Ms as the suffix, not MS.

https://codereview.chromium.org/2326553003/diff/80001/remoting/host/it2me/it2...
remoting/host/it2me/it2me_confirmation_dialog_win.cc:63: LONG_PTR dwRefData);
Please update parameter names to avoid Hungarian notation and camel casing.

[joedow, 2016-09-13 15:06:42]

Thanks!

https://codereview.chromium.org/2326553003/diff/80001/remoting/host/it2me/it2...
File remoting/host/it2me/it2me_confirmation_dialog_win.cc (right):

https://codereview.chromium.org/2326553003/diff/80001/remoting/host/it2me/it2...
remoting/host/it2me/it2me_confirmation_dialog_win.cc:28: const int
kDialogTimeoutMS = 60 * 1000;
On 2016/09/13 00:13:56, Sergey Ulanov wrote:
> TimeDelta constructor is declared as constexpr now, so we can use it for
> constants:
> 
> constexpr base::TimeDelta kDialogTimeout = base::TimeDelta::FromMinutes(1).
> 
> If you keep it as int then please use Ms as the suffix, not MS.

Will switch to TimeDelta in my next CL.  Changing the suffix for this one.

https://codereview.chromium.org/2326553003/diff/80001/remoting/host/it2me/it2...
remoting/host/it2me/it2me_confirmation_dialog_win.cc:63: LONG_PTR dwRefData);
On 2016/09/13 00:13:56, Sergey Ulanov wrote:
> Please update parameter names to avoid Hungarian notation and camel casing.

Darn MSDN :P

[joedow, 2016-09-13 15:06:49]

The CQ bit was checked by joedow@chromium.org

[joedow, 2016-09-13 15:06:49]

The patchset sent to the CQ was uploaded after l-g-t-m from sergeyu@chromium.org
Link to the patchset: https://codereview.chromium.org/2326553003/#ps100001
(title: "Addressing CR feedback")

[commit-bot: I haz the power, 2016-09-13 15:07:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 16:06:22]

Committed patchset #5 (id:100001)

[commit-bot: I haz the power, 2016-09-13 16:08:32]

Description was changed from

==========
Adding a Confirmation dialog for It2Me on Windows

This change adds a confirmation dialog for Windows for the It2Me host.  I've
also added placeholder files for the other platforms (beyond ChromeOS).  This
dialog is displayed when the remote user begins the connection process and
shows the email address of the remote user and gives the local user a chance to
accept/reject the connection.

BUG=645540
==========

to

==========
Adding a Confirmation dialog for It2Me on Windows

This change adds a confirmation dialog for Windows for the It2Me host.  I've
also added placeholder files for the other platforms (beyond ChromeOS).  This
dialog is displayed when the remote user begins the connection process and
shows the email address of the remote user and gives the local user a chance to
accept/reject the connection.

BUG=645540

Committed: https://crrev.com/7cc2c86157e6a02a575ea610339983273de38b85
Cr-Commit-Position: refs/heads/master@{#418261}
==========

[commit-bot: I haz the power, 2016-09-13 16:08:33]

Patchset 5 (id:??) landed as
https://crrev.com/7cc2c86157e6a02a575ea610339983273de38b85
Cr-Commit-Position: refs/heads/master@{#418261}