x11_util: Added GetInnerWindowBounds and GetWindowExtents.

x11_util: Added GetInnerWindowBounds and GetWindowExtents.

Renamed GetWindowRect to GetOuterWindowBounds, and re-implemented it in
terms of GetInnerWindowBounds and GetWindowExtents.

The separate access to inner bounds and extents can be used to cache
extents to avoid having to query them repeatedly when they hardly ever
change.

BUG=357533
TBR=erg@chromium.org

Committed: https://crrev.com/a42b23be397906c8d9a35da7a3e0c3b0e39fefd3
Cr-Commit-Position: refs/heads/master@{#299572}

[Matt Giuca, 2014-10-14 00:25:58]

mgiuca@chromium.org changed reviewers:
+ derat@chromium.org

[Matt Giuca, 2014-10-14 00:25:59]

Hi Dan,

This is a precursor to https://codereview.chromium.org/216763002/. It's unclear
whether that CL will go through (it's complicated), but I think this one is a
useful refactor and rename regardless.

(Sadrul was originally part of that discussion, but he's OOO for awhile.)

https://codereview.chromium.org/232653002/diff/20001/ui/base/x/x11_util.cc
File ui/base/x/x11_util.cc (right):

https://codereview.chromium.org/232653002/diff/20001/ui/base/x/x11_util.cc#ne...
ui/base/x/x11_util.cc:658: extents->Set(-top, -left, -bottom, -right);
Note that Rect::Inset takes (left, top, right, bottom), whereas Insets::Set
takes (top, left, bottom, right), which explains the reordering of the arguments
here.

[Daniel Erat, 2014-10-14 14:17:03]

lgtm

looks great!

[Matt Giuca, 2014-10-14 17:37:36]

The CQ bit was checked by mgiuca@chromium.org

[commit-bot: I haz the power, 2014-10-14 17:38:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/232653002/20001

[commit-bot: I haz the power, 2014-10-14 17:54:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-14 17:54:42]

Try jobs failed on following builders:
  linux_chromium_gn_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Matt Giuca, 2014-10-14 21:58:58]

mgiuca@chromium.org changed reviewers:
+ erg@chromium.org

[Matt Giuca, 2014-10-14 21:58:59]

Adding erg for desktop_window_tree_host_x11_unittest.cc (TBR; mechanical
change).

[Matt Giuca, 2014-10-14 21:59:09]

The CQ bit was checked by mgiuca@chromium.org

[Elliot Glaysher, 2014-10-14 21:59:26]

lgtm

[commit-bot: I haz the power, 2014-10-14 22:00:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/232653002/40001

[commit-bot: I haz the power, 2014-10-14 22:47:37]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-10-14 22:48:16]

Patchset 3 (id:??) landed as
https://crrev.com/a42b23be397906c8d9a35da7a3e0c3b0e39fefd3
Cr-Commit-Position: refs/heads/master@{#299572}