Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 2326523004: Revert of StackFrameDepth should be managed per ThreadHeap (Closed)

Created:
4 years, 3 months ago by keishi
Modified:
4 years, 3 months ago
Reviewers:
haraken, oilpan-reviews
CC:
chromium-reviews, blink-reviews, kouhei+heap_chromium.org, oilpan-reviews, Mads Ager (chromium)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of StackFrameDepth should be managed per ThreadHeap (patchset #7 id:120001 of https://codereview.chromium.org/2304023003/ ) Reason for revert: Caused FetchDataConsumerTeeTest.CreateFromBlobWithInvalidSize and FetchDataConsumerTeeTest.Create to fail https://bugs.chromium.org/p/chromium/issues/detail?id=645253 Original issue's description: > StackFrameDepth should be managed per ThreadHeap > > StackFrameDepth should be managed per ThreadHeap so we won't have issues when we run multiple GCs simultaniously. > > BUG= > > Committed: https://crrev.com/098b330a204a365b70d381ca9b3e51a9ca7efc29 > Cr-Commit-Position: refs/heads/master@{#416908} TBR=haraken@chromium.org,oilpan-reviews@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -26 lines) Patch
M third_party/WebKit/Source/platform/heap/Heap.h View 3 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/Heap.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/StackFrameDepth.h View 3 chunks +15 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/StackFrameDepth.cpp View 3 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/TraceTraits.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
keishi
Created Revert of StackFrameDepth should be managed per ThreadHeap
4 years, 3 months ago (2016-09-09 05:02:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2326523004/1
4 years, 3 months ago (2016-09-09 05:02:19 UTC) #3
haraken
4 years, 3 months ago (2016-09-09 05:14:52 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698