Site Settings Desktop: In the Zoom category, use cross icon instead of trashcan.

Site Settings Desktop: In the Zoom category, use cross icon instead of trashcan.

TBR=michaelpg
BUG=645270
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/8e45c7b614dab5a62f0425e0752567b59a4035d5
Cr-Commit-Position: refs/heads/master@{#419709}

[Finnur, 2016-09-09 14:42:39]

Description was changed from

==========
Site Settings Desktop: In the Zoom category, use cross icon instead of trashcan.

BUG=645270
==========

to

==========
Site Settings Desktop: In the Zoom category, use cross icon instead of trashcan.

BUG=645270
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Finnur, 2016-09-09 14:43:02]

The CQ bit was checked by finnur@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-09 14:43:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Finnur, 2016-09-09 14:43:25]

finnur@chromium.org changed reviewers:
+ dschuyler@chromium.org

[commit-bot: I haz the power, 2016-09-09 16:11:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-09 16:11:25]

Dry run: This issue passed the CQ dry run.

[Dan Beam, 2016-09-09 16:36:50]

dbeam@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2016-09-09 16:36:50]

https://codereview.chromium.org/2326473004/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/icons.html (right):

https://codereview.chromium.org/2326473004/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/icons.html:53: <g id="clear"><path d="M19
6.41L17.59 5 12 10.59 6.41 5 5 6.41 10.59 12 5 17.59 6.41 19 12 13.41 17.59 19
19 17.59 13.41 12z"><path></g>
use this one instead of adding another
https://cs.chromium.org/chromium/src/ui/webui/resources/cr_elements/icons.htm...

https://codereview.chromium.org/2326473004/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/site_settings/zoom_levels.html (right):

https://codereview.chromium.org/2326473004/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/site_settings/zoom_levels.html:33:
<paper-icon-button icon="settings:clear"
cr:clear

[dschuyler, 2016-09-09 16:53:29]

Finnur, should some of these change as well:
https://cs.chromium.org/search/?q=settings:delete&sq=package:chromium&type=cs

[Dan Beam, 2016-09-09 17:03:08]

On 2016/09/09 16:53:29, dschuyler wrote:
> Finnur, should some of these change as well:
> https://cs.chromium.org/search/?q=settings:delete&sq=package:chromium&type=cs

if it's used on multiple pages, use the ui/webui/resources/ version

if the icon's used on just your page, put it in your page's icons.html

i don't see an existing delete icon in
https://cs.chromium.org/chromium/src/ui/webui/resources/cr_elements/icons.html,
so unless it's already used in extensions/downloads/history or whatever, just
put page-specific icons in page-specific locations.

[Finnur, 2016-09-16 14:42:39]

Patchset #2 (id:20001) has been deleted

[Finnur, 2016-09-19 10:18:59]

The CQ bit was checked by finnur@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 10:19:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 10:21:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-19 10:21:16]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Finnur, 2016-09-19 10:23:01]

The Zoom level page is now using the cross icon (instead of the trashcan) and
I've moved the delete icon into cr_elements/icons.html because it is very
generic and both Settings and Chrome OS emulator pages use it. All the Settings
pages have, in this CL, been updated to use it and I'll follow up separately
once this is checked in to get the ChromeOS emulator pages to use the common
icon.

PTAL

[Finnur, 2016-09-19 10:40:19]

The CQ bit was checked by finnur@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 10:40:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 11:29:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-19 11:29:45]

Dry run: This issue passed the CQ dry run.

[dschuyler, 2016-09-19 19:04:34]

lgtm

[Finnur, 2016-09-19 21:33:33]

The CQ bit was checked by finnur@chromium.org

[commit-bot: I haz the power, 2016-09-19 21:34:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 21:45:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-19 21:45:14]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Dan Beam, 2016-09-19 23:59:23]

owner stamp lgtm

[Finnur, 2016-09-20 09:43:52]

Description was changed from

==========
Site Settings Desktop: In the Zoom category, use cross icon instead of trashcan.

BUG=645270
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Site Settings Desktop: In the Zoom category, use cross icon instead of trashcan.

TBR=michaelpg
BUG=645270
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Finnur, 2016-09-20 09:43:53]

finnur@chromium.org changed reviewers:
+ michaelpg@chromium.org

[Finnur, 2016-09-20 09:44:22]

Adding Michael TBR for OWNERs approval for the main icons.html.

[Finnur, 2016-09-20 09:44:30]

The CQ bit was checked by finnur@chromium.org

[commit-bot: I haz the power, 2016-09-20 09:44:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 09:49:40]

Description was changed from

==========
Site Settings Desktop: In the Zoom category, use cross icon instead of trashcan.

TBR=michaelpg
BUG=645270
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Site Settings Desktop: In the Zoom category, use cross icon instead of trashcan.

TBR=michaelpg
BUG=645270
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-09-20 09:49:41]

Committed patchset #5 (id:100001)

[commit-bot: I haz the power, 2016-09-20 09:51:30]

Description was changed from

==========
Site Settings Desktop: In the Zoom category, use cross icon instead of trashcan.

TBR=michaelpg
BUG=645270
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Site Settings Desktop: In the Zoom category, use cross icon instead of trashcan.

TBR=michaelpg
BUG=645270
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/8e45c7b614dab5a62f0425e0752567b59a4035d5
Cr-Commit-Position: refs/heads/master@{#419709}
==========

[commit-bot: I haz the power, 2016-09-20 09:51:31]

Patchset 5 (id:??) landed as
https://crrev.com/8e45c7b614dab5a62f0425e0752567b59a4035d5
Cr-Commit-Position: refs/heads/master@{#419709}