Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 2326473004: Site Settings Desktop: In the Zoom category, use cross icon instead of trashcan. (Closed)

Created:
4 years, 3 months ago by Finnur
Modified:
4 years, 3 months ago
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Site Settings Desktop: In the Zoom category, use cross icon instead of trashcan. TBR=michaelpg BUG=645270 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/8e45c7b614dab5a62f0425e0752567b59a4035d5 Cr-Commit-Position: refs/heads/master@{#419709}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address feedback #

Patch Set 3 : Address feedback #

Patch Set 4 : Sync #

Patch Set 5 : Polish #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -8 lines) Patch
M chrome/browser/resources/settings/icons.html View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/people_page/change_picture.html View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/site_settings/site_data.html View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/site_settings/site_details.html View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/site_settings/zoom_levels.html View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/webui/resources/cr_elements/icons.html View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 36 (23 generated)
Finnur
4 years, 3 months ago (2016-09-09 14:43:25 UTC) #5
Dan Beam
https://codereview.chromium.org/2326473004/diff/1/chrome/browser/resources/settings/icons.html File chrome/browser/resources/settings/icons.html (right): https://codereview.chromium.org/2326473004/diff/1/chrome/browser/resources/settings/icons.html#newcode53 chrome/browser/resources/settings/icons.html:53: <g id="clear"><path d="M19 6.41L17.59 5 12 10.59 6.41 5 ...
4 years, 3 months ago (2016-09-09 16:36:50 UTC) #9
dschuyler
Finnur, should some of these change as well: https://cs.chromium.org/search/?q=settings:delete&sq=package:chromium&type=cs
4 years, 3 months ago (2016-09-09 16:53:29 UTC) #10
Dan Beam
On 2016/09/09 16:53:29, dschuyler wrote: > Finnur, should some of these change as well: > ...
4 years, 3 months ago (2016-09-09 17:03:08 UTC) #11
Finnur
The Zoom level page is now using the cross icon (instead of the trashcan) and ...
4 years, 3 months ago (2016-09-19 10:23:01 UTC) #17
dschuyler
lgtm
4 years, 3 months ago (2016-09-19 19:04:34 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2326473004/100001
4 years, 3 months ago (2016-09-19 21:34:37 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/262370)
4 years, 3 months ago (2016-09-19 21:45:14 UTC) #26
Dan Beam
owner stamp lgtm
4 years, 3 months ago (2016-09-19 23:59:23 UTC) #27
Finnur
Adding Michael TBR for OWNERs approval for the main icons.html.
4 years, 3 months ago (2016-09-20 09:44:22 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2326473004/100001
4 years, 3 months ago (2016-09-20 09:44:40 UTC) #32
commit-bot: I haz the power
Committed patchset #5 (id:100001)
4 years, 3 months ago (2016-09-20 09:49:41 UTC) #34
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 09:51:31 UTC) #36
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/8e45c7b614dab5a62f0425e0752567b59a4035d5
Cr-Commit-Position: refs/heads/master@{#419709}

Powered by Google App Engine
This is Rietveld 408576698