Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2326473002: Revert of Do a better job at faking simple challenge signatures. (Closed)

Created:
4 years, 3 months ago by achuithb
Modified:
4 years, 3 months ago
CC:
chromium-reviews, hashimoto+watch_chromium.org, oshima+watch_chromium.org, dkalin1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Do a better job at faking simple challenge signatures. (patchset #7 id:120001 of https://codereview.chromium.org/2297193006/ ) Reason for revert: crbug.com/645052 This is causing build_package failures on chromeos. Original issue's description: > Do a better job at faking simple challenge signatures. > > By returning a signed simple challenge that can actually be parsed as SignedData, we allow callers of the FakeCryptohomeClient to extract the original data back and process it, making for better fake behavior and simpler tests. > > Note that the signature is purposedly not verifiable in the FakeCryptohomeClient. > > BUG=643245 > TEST=chromeos_unittests; unit_tests and components_unittests also pass > > Committed: https://crrev.com/911199cb30f608636c79d47e50dca84735e3a08f > Cr-Commit-Position: refs/heads/master@{#417118} TBR=dkrahn@chromium.org,xiyuan@chromium.org,drcrash@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=643245 Committed: https://crrev.com/746d1dd68119cacc6636152921db9f1e88d92c52 Cr-Commit-Position: refs/heads/master@{#417242}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -188 lines) Patch
M chrome/browser/chromeos/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
A chrome/browser/chromeos/attestation/attestation_signed_data.proto View 1 chunk +17 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/attestation/platform_verification_flow.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chromeos/BUILD.gn View 5 chunks +0 lines, -12 lines 0 comments Download
M chromeos/chromeos.gyp View 3 chunks +0 lines, -16 lines 0 comments Download
M chromeos/dbus/fake_cryptohome_client.h View 1 chunk +6 lines, -12 lines 0 comments Download
M chromeos/dbus/fake_cryptohome_client.cc View 13 chunks +26 lines, -52 lines 0 comments Download
D chromeos/dbus/fake_cryptohome_client_unittest.cc View 1 chunk +0 lines, -76 lines 0 comments Download
D chromeos/dbus/proto/attestation.proto View 1 chunk +0 lines, -17 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
achuithb
Created Revert of Do a better job at faking simple challenge signatures.
4 years, 3 months ago (2016-09-08 09:50:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2326473002/1
4 years, 3 months ago (2016-09-08 09:50:24 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-08 09:51:19 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 09:53:13 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/746d1dd68119cacc6636152921db9f1e88d92c52
Cr-Commit-Position: refs/heads/master@{#417242}

Powered by Google App Engine
This is Rietveld 408576698