Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2326453002: Modified MIPS MSA default argument settings (Closed)

Created:
4 years, 3 months ago by manojkumar.bhosale
Modified:
4 years, 3 months ago
Reviewers:
Dirk Pranke, Nico, gordana.cmiljanovic
CC:
chromium-reviews, parag.salasakar_imgtec.com, kaustubh.raste_imgtec.com
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Modified MIPS MSA default argument settings 1. Disabled msa by default 2. Removed compiler flags R=dpranke@chromium.org BUG= Committed: https://crrev.com/47a0672f5b94140cfbed534b180c7b81a500de0c Cr-Commit-Position: refs/heads/master@{#419419}

Patch Set 1 #

Patch Set 2 : Revert build/common.gypi #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M build/config/compiler/BUILD.gn View 2 chunks +0 lines, -4 lines 0 comments Download
M build/config/mips.gni View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 15 (6 generated)
manojkumar.bhosale
4 years, 3 months ago (2016-09-08 06:29:46 UTC) #1
manojkumar.bhosale
4 years, 3 months ago (2016-09-08 06:39:57 UTC) #4
Dirk Pranke
You don't need to (and shouldn't) modify common.gypi at this point. lgtm otherwise.
4 years, 3 months ago (2016-09-08 22:10:54 UTC) #5
manojkumar.bhosale
On 2016/09/08 22:10:54, Dirk Pranke wrote: > You don't need to (and shouldn't) modify common.gypi ...
4 years, 3 months ago (2016-09-13 06:28:08 UTC) #6
Dirk Pranke
On 2016/09/13 06:28:08, manojkumar.bhosale wrote: > On 2016/09/08 22:10:54, Dirk Pranke wrote: > > You ...
4 years, 3 months ago (2016-09-13 21:39:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2326453002/20001
4 years, 3 months ago (2016-09-19 08:27:01 UTC) #10
manojkumar.bhosale
4 years, 3 months ago (2016-09-19 08:27:16 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-19 08:40:21 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-19 08:41:46 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/47a0672f5b94140cfbed534b180c7b81a500de0c
Cr-Commit-Position: refs/heads/master@{#419419}

Powered by Google App Engine
This is Rietveld 408576698