[chromedriver] Discard pending frames except for the frame we just navigated to.

[chromedriver] Discard pending frames except for the frame we just navigated to.

BUG=646447
Committed: https://crrev.com/eeb7279129a81aedf02efd7b2ece7537dec22789
Cr-Commit-Position: refs/heads/master@{#420054}

[samuong, 2016-09-13 22:00:55]

Patchset #2 (id:20001) has been deleted

[samuong, 2016-09-13 22:20:44]

Description was changed from

==========
[chromedriver] Discard pending frames except for the frame we just navigated to.

BUG=
==========

to

==========
[chromedriver] Discard pending frames except for the frame we just navigated to.

BUG=646447
==========

[samuong, 2016-09-13 22:20:54]

samuong@chromium.org changed reviewers:
+ stgao@chromium.org

[samuong, 2016-09-13 22:20:54]

ptal

[stgao, 2016-09-20 23:44:19]

Frankly speaking, I'm not sure whether this solution would introduce any side
effect due to the complex scenarios of possible navigation. But the code looks
good to me, so lgtm.

https://codereview.chromium.org/2326443002/diff/40001/chrome/test/chromedrive...
File chrome/test/chromedriver/chrome/navigation_tracker.cc (right):

https://codereview.chromium.org/2326443002/diff/40001/chrome/test/chromedrive...
chrome/test/chromedriver/chrome/navigation_tracker.cc:284: // Discard pending
and scheduled frames, except for the frame that just
It might worth mentioning this is the root frame.

[stgao, 2016-09-20 23:45:38]

https://codereview.chromium.org/2326443002/diff/40001/chrome/test/chromedrive...
File chrome/test/chromedriver/chrome/navigation_tracker.cc (right):

https://codereview.chromium.org/2326443002/diff/40001/chrome/test/chromedrive...
chrome/test/chromedriver/chrome/navigation_tracker.cc:224: // Versions of Chrome
with build number 1916 and earlier do not contain this
Nit: I guess this part could be cleaned now.

[samuong, 2016-09-21 14:36:56]

This doesn't introduce any regressions in global presubmits, and has been
running in google3 for almost a week now, so I don't believe there are any
unintended side-effects. See the internal bug for details (there's a b/ link in
the external bug description).

https://codereview.chromium.org/2326443002/diff/40001/chrome/test/chromedrive...
File chrome/test/chromedriver/chrome/navigation_tracker.cc (right):

https://codereview.chromium.org/2326443002/diff/40001/chrome/test/chromedrive...
chrome/test/chromedriver/chrome/navigation_tracker.cc:224: // Versions of Chrome
with build number 1916 and earlier do not contain this
On 2016/09/20 23:45:38, stgao (slow) wrote:
> Nit: I guess this part could be cleaned now.

Unfortunately we still need to keep this around for WebView on KitKat :(

https://codereview.chromium.org/2326443002/diff/40001/chrome/test/chromedrive...
chrome/test/chromedriver/chrome/navigation_tracker.cc:284: // Discard pending
and scheduled frames, except for the frame that just
On 2016/09/20 23:44:19, stgao (slow) wrote:
> It might worth mentioning this is the root frame.

Done.

[samuong, 2016-09-21 14:37:53]

The CQ bit was checked by samuong@chromium.org

[samuong, 2016-09-21 14:37:54]

The patchset sent to the CQ was uploaded after l-g-t-m from stgao@chromium.org
Link to the patchset: https://codereview.chromium.org/2326443002/#ps60001
(title: "tweak wording of comment")

[commit-bot: I haz the power, 2016-09-21 14:38:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 14:48:38]

Description was changed from

==========
[chromedriver] Discard pending frames except for the frame we just navigated to.

BUG=646447
==========

to

==========
[chromedriver] Discard pending frames except for the frame we just navigated to.

BUG=646447
==========

[commit-bot: I haz the power, 2016-09-21 14:48:39]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-09-21 14:50:03]

Description was changed from

==========
[chromedriver] Discard pending frames except for the frame we just navigated to.

BUG=646447
==========

to

==========
[chromedriver] Discard pending frames except for the frame we just navigated to.

BUG=646447

Committed: https://crrev.com/eeb7279129a81aedf02efd7b2ece7537dec22789
Cr-Commit-Position: refs/heads/master@{#420054}
==========

[commit-bot: I haz the power, 2016-09-21 14:50:03]

Patchset 3 (id:??) landed as
https://crrev.com/eeb7279129a81aedf02efd7b2ece7537dec22789
Cr-Commit-Position: refs/heads/master@{#420054}