Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1164)

Unified Diff: content/renderer/render_view_browsertest.cc

Issue 23264032: Fix content browser test failure by enabling WebRuntimeFeatures::enableInputModeAttribute (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_view_browsertest.cc
diff --git a/content/renderer/render_view_browsertest.cc b/content/renderer/render_view_browsertest.cc
index 7c1715e9e80eb603b309bdd4a38bf577793c37f9..8fef314b54f7e5523da69f6c68d4c1ad874f1141 100644
--- a/content/renderer/render_view_browsertest.cc
+++ b/content/renderer/render_view_browsertest.cc
@@ -34,6 +34,7 @@
#include "third_party/WebKit/public/web/WebDataSource.h"
#include "third_party/WebKit/public/web/WebFrame.h"
#include "third_party/WebKit/public/web/WebHistoryItem.h"
+#include "third_party/WebKit/public/web/WebRuntimeFeatures.h"
#include "third_party/WebKit/public/web/WebView.h"
#include "third_party/WebKit/public/web/WebWindowFeatures.h"
#include "ui/base/keycodes/keyboard_codes.h"
@@ -771,10 +772,11 @@ TEST_F(RenderViewImplTest, DontIgnoreBackAfterNavEntryLimit) {
// Test that our IME backend sends a notification message when the input focus
// changes.
-// crbug.com/276821:
-// Because Blink change cause this test failed, we first disabled this test and
-// fix later.
-TEST_F(RenderViewImplTest, DISABLED_OnImeTypeChanged) {
+TEST_F(RenderViewImplTest, OnImeTypeChanged) {
+ // This test depends on Blink flag InputModeAttribute, which is enabled under
+ // only test. Content browser test doesn't enable the features so we need
+ // enable manually.
+ WebKit::WebRuntimeFeatures::enableTestOnlyFeatures(true);
kochi 2013/08/22 04:00:22 Can you enable only InputMode, and not in test fun
yoichio 2013/08/22 06:00:46 Done.
// Enable our IME backend code.
view()->OnSetInputMethodActive(true);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698