Move Android to use new Popup Blocker API.

chrome/browser/ui/android/tab_model/tab_model_list.cc

Index: chrome/browser/ui/android/tab_model/tab_model_list.cc
diff --git a/chrome/browser/ui/android/tab_model/tab_model_list.cc b/chrome/browser/ui/android/tab_model/tab_model_list.cc
index aecd9e44786d14db1b11057a76b19d3aca62a232..fce489a55153121744f7256e090382883d73095f 100644
--- a/chrome/browser/ui/android/tab_model/tab_model_list.cc
+++ b/chrome/browser/ui/android/tab_model/tab_model_list.cc
@@ -4,8 +4,10 @@
 
 #include "chrome/browser/ui/android/tab_model/tab_model_list.h"
 
+#include "chrome/browser/android/tab_android.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/android/tab_model/tab_model.h"
+#include "chrome/browser/ui/browser_navigator.h"
 
 namespace {
 
@@ -32,6 +34,14 @@ void TabModelList::RemoveTabModel(TabModel* tab_model) {
     tab_models().erase(remove_tab_model);
 }
 
+void TabModelList::HandleNavigation(chrome::NavigateParams* params) {
+  TabAndroid* tab = TabAndroid::FromWebContents(params->source_contents);
+
+  if (tab)

[Yaron, 2013/08/21 19:07:58]

Hmm. How does this happen? We've create a new web contents and it's not
associated with a tab? From prerendering? I'm not saying it can't, I'd like to
understand it better though.

[David Trainor- moved to gerrit, 2013/08/21 20:21:27]

The issue is popups can be blocked inside
ChromeContentBrowserClient::CanCreateWindow now.  The problem with this is that
it's moved out of ChromeWebContentsDelegateAndroid which used to pretty much
guarantee we had a TabAndroid (as that was the thing that registered the
delegate).  In this case I don't know that I can safely make that assumption...

I can add a DCHECK to catch any instances where we are dropping these calls on
the floor and we can hopefully catch them.  I would doubt that we'd see this
happen though.  Prerendering would be the only time I could see this being NULL,
but if we blocked and tried to show the popup here the user must have clicked on
the UI to allow popups through, which wouldn't show on a page that is being
prerendered I think.

[Yaron, 2013/08/22 00:36:30]

Ok, so update the DCHECK with a message to contact dtrainor/yfriedman with more
information if this happens. Also, drop the "if" on the next line

+    tab->HandleNavigation(params);

[jochen (gone - plz use gerrit), 2013/08/21 08:05:25]

does HandleNavigation() support params.should_set_opener?

I wonder whether there's a way to make the popup blocker browsertest run on
android

[David Trainor- moved to gerrit, 2013/08/21 17:25:13]

When the tab talks to the model in Java it can specify whether or not it wants
to be a parent, which can be based on should_set_opener (I'm making an
assumption on what this flag means based on the description if I'm wrong let me
know!).

We don't fully support NavigateParams yet, but I wanted to add basic support so
the Popups will work.

[Yaron, 2013/08/21 19:09:46]

Not really. chrome/ layer Browsertests rely on Browser which isn't used on
Android. It would be nice to have this abstracted some way but I think that's a
nontrivial amount of work

+}
+
+
 TabModel* TabModelList::GetTabModelWithProfile(
     Profile* profile) {
   if (!profile)