Move Android to use new Popup Blocker API.

components/web_contents_delegate_android/web_contents_delegate_android.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/web_contents_delegate_android/web_contents_delegate_android.h"
 
 #include <android/keycodes.h>
 
 #include "base/android/jni_android.h"
 #include "base/android/jni_array.h"
@@ skipping 117 matching lines @@
     WebContents* source,
     WebContents* new_contents,
     WindowOpenDisposition disposition,
     const gfx::Rect& initial_pos,
     bool user_gesture,
     bool* was_blocked) {
   JNIEnv* env = AttachCurrentThread();
   ScopedJavaLocalRef<jobject> obj = GetJavaDelegate(env);
   bool handled = false;
   if (!obj.is_null()) {
     handled = Java_WebContentsDelegateAndroid_addNewContents(

[joth, 2013/08/20 22:44:36]

note this method isn't used in webview (see
https://code.google.com/p/chromium/codesearch#chromium/src/android_webview/ja...)
so it might be clearer for everyone to remove it from WCDA and put it straight
into ChromeWebContentsDelegate

pretty please :-)

[David Trainor- moved to gerrit, 2013/08/21 17:25:13]

If you guys don't use it sure!

[Yaron, 2013/08/21 19:07:58]

+1

         env,
         obj.obj(),
         reinterpret_cast<jint>(source),
         reinterpret_cast<jint>(new_contents),
         static_cast<jint>(disposition),
         NULL,
         user_gesture);
   }
+
+  if (was_blocked)
+    *was_blocked = false;

[joth, 2013/08/20 22:44:36]

seems like this should be !handled  instead of false?

[David Trainor- moved to gerrit, 2013/08/21 17:25:13]

I wasn't sure if whether or not we handled it actually meant it was blocked or
not.  If we just don't show it it wasn't blocked?  I can remove this line for
now though and address it in another CL as it's kind of independent.

+
   if (!handled)
     delete new_contents;
 }
 
 void WebContentsDelegateAndroid::ActivateContents(WebContents* contents) {
   JNIEnv* env = AttachCurrentThread();
   ScopedJavaLocalRef<jobject> obj = GetJavaDelegate(env);
   if (obj.is_null())
     return;
   Java_WebContentsDelegateAndroid_activateContents(env, obj.obj());
@@ skipping 195 matching lines @@
 
 bool RegisterWebContentsDelegateAndroid(JNIEnv* env) {
   if (!HasClass(env, kWebContentsDelegateAndroidClassPath)) {
     DLOG(ERROR) << "Unable to find class WebContentsDelegateAndroid!";
     return false;
   }
   return RegisterNativesImpl(env);
 }
 
 }  // namespace web_contents_delegate_android