Move Android to use new Popup Blocker API.

chrome/browser/android/tab_android.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_ANDROID_TAB_ANDROID_H_
 #define CHROME_BROWSER_ANDROID_TAB_ANDROID_H_
 
 #include <jni.h>
 
 #include "base/android/jni_helper.h"
 #include "base/callback_forward.h"
 #include "base/strings/string16.h"
 #include "chrome/browser/sessions/session_id.h"
 #include "chrome/browser/ui/toolbar/toolbar_model.h"
 
 class GURL;
 class SkBitmap;
 
 namespace browser_sync {
 class SyncedTabDelegate;
 }
 
+namespace chrome {
+struct NavigateParams;
+}
+
 namespace content {
 struct ContextMenuParams;
 class WebContents;
 }
 
 class TabAndroid {
  public:
   TabAndroid(JNIEnv* env, jobject obj);
 
   // Convenience method to retrieve the Tab associated with the passed
   // WebContents.  Can return NULL.
   static TabAndroid* FromWebContents(content::WebContents* web_contents);
 
   static TabAndroid* GetNativeTab(JNIEnv* env, jobject obj);
 
   // TODO(tedchoc): Make pure virtual once all derived classes can be updated.
   virtual content::WebContents* GetWebContents();
 
   virtual browser_sync::SyncedTabDelegate* GetSyncedTabDelegate() = 0;
 
   virtual ToolbarModel::SecurityLevel GetSecurityLevel();
 
   const SessionID& id() const { return tab_id_; }
 
+  virtual void HandleNavigation(chrome::NavigateParams* params) = 0;

[Yaron, 2013/08/22 00:36:30]

I don't think TestShell will link. To this end, could we test popup blocker in
testshell after this change or does it also require
https://codereview.chromium.org/23020009/?

Also, it's a little strange that this is only used by blocked popup case (i.e.
someone looking at the code might expect all navigations to go through here). We
discussed this briefly offline and I think it'd be hard to get all navigations
to go through this one path. Maybe instead we should rename this so it's clear
it's for handling a navigation with a popup.

+
   virtual void OnReceivedHttpAuthRequest(jobject auth_handler,
                                          const string16& host,
                                          const string16& realm) = 0;
 
   // Called to show the regular context menu that is triggered by a long press.
   virtual void ShowContextMenu(const content::ContextMenuParams& params) = 0;
 
   // Called to show a custom context menu. Used by the NTP.
   virtual void ShowCustomContextMenu(
       const content::ContextMenuParams& params,
@@ skipping 26 matching lines @@
   // TODO(jknotten): Remove this method. Making it non-abstract, so that
   // derived classes may remove their implementation first.
   virtual void RunExternalProtocolDialog(const GURL& url);
 
   // Used by sync to get/set the sync id of tab.
   virtual int GetSyncId() const = 0;
   virtual void SetSyncId(int sync_id) = 0;
 
   static bool RegisterTabAndroid(JNIEnv* env);
 
+  static void InitTabHelpers(content::WebContents* web_contents);
+
  protected:
   virtual ~TabAndroid();
 
-  static void InitTabHelpers(content::WebContents* web_contents);
-
   content::WebContents* InitWebContentsFromView(JNIEnv* env,
                                                 jobject content_view);
 
   SessionID tab_id_;
 
  private:
   JavaObjectWeakGlobalRef weak_java_tab_;
 };
 
 #endif  // CHROME_BROWSER_ANDROID_TAB_ANDROID_H_