Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(906)

Side by Side Diff: src/debug.cc

Issue 23264015: In reporting step-in positions be more accurate with a position the debugger paused at (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: follow code review Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/runtime.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 385 matching lines...) Expand 10 before | Expand all | Expand 10 after
396 ClearDebugBreakAtSlot(); 396 ClearDebugBreakAtSlot();
397 } else { 397 } else {
398 // Patch the IC call. 398 // Patch the IC call.
399 ClearDebugBreakAtIC(); 399 ClearDebugBreakAtIC();
400 } 400 }
401 ASSERT(!IsDebugBreak()); 401 ASSERT(!IsDebugBreak());
402 } 402 }
403 403
404 404
405 bool BreakLocationIterator::IsStepInLocation(Isolate* isolate) { 405 bool BreakLocationIterator::IsStepInLocation(Isolate* isolate) {
406 if (RelocInfo::IsConstructCall(rmode())) { 406 if (RelocInfo::IsConstructCall(original_rmode())) {
407 return true; 407 return true;
408 } else if (RelocInfo::IsCodeTarget(rmode())) { 408 } else if (RelocInfo::IsCodeTarget(rmode())) {
409 HandleScope scope(debug_info_->GetIsolate()); 409 HandleScope scope(debug_info_->GetIsolate());
410 Address target = rinfo()->target_address(); 410 Address target = original_rinfo()->target_address();
411 Handle<Code> target_code(Code::GetCodeFromTargetAddress(target)); 411 Handle<Code> target_code(Code::GetCodeFromTargetAddress(target));
412 if (target_code->kind() == Code::STUB) { 412 if (target_code->kind() == Code::STUB) {
413 return target_code->major_key() == CodeStub::CallFunction; 413 return target_code->major_key() == CodeStub::CallFunction;
414 } 414 }
415 return target_code->is_call_stub() || target_code->is_keyed_call_stub(); 415 return target_code->is_call_stub() || target_code->is_keyed_call_stub();
416 } else { 416 } else {
417 return false; 417 return false;
418 } 418 }
419 } 419 }
420 420
(...skipping 3433 matching lines...) Expand 10 before | Expand all | Expand 10 after
3854 { 3854 {
3855 Locker locker(reinterpret_cast<v8::Isolate*>(isolate_)); 3855 Locker locker(reinterpret_cast<v8::Isolate*>(isolate_));
3856 isolate_->debugger()->CallMessageDispatchHandler(); 3856 isolate_->debugger()->CallMessageDispatchHandler();
3857 } 3857 }
3858 } 3858 }
3859 } 3859 }
3860 3860
3861 #endif // ENABLE_DEBUGGER_SUPPORT 3861 #endif // ENABLE_DEBUGGER_SUPPORT
3862 3862
3863 } } // namespace v8::internal 3863 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/runtime.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698