Issue 23264015: In reporting step-in positions be more accurate with a position the debugger paused at

Issue 23264015: In reporting step-in positions be more accurate with a position the debugger paused at (Closed)

Created:
7 years, 4 months ago by Peter.Rybin

Modified:
7 years, 3 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

In reporting step-in positions be more accurate with a position the debugger paused at R=yangguo@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=16472

Patch Set 4 : follow code review #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+120 lines, -18 lines)			Patch
M	src/debug.cc	View	1 2 3	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/runtime.cc	View	1 2 3	2 chunks	+20 lines, -1 line	0 comments	Download
M	test/mjsunit/debug-stepin-positions.js	View	1 2 3	3 chunks	+98 lines, -15 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Yang

LGTM with comments. https://codereview.chromium.org/23264015/diff/5001/src/runtime.cc File src/runtime.cc (right): https://codereview.chromium.org/23264015/diff/5001/src/runtime.cc#newcode12022 src/runtime.cc:12022: if (frame_it.done()) { you could use ...

7 years, 3 months ago (2013-08-26 13:52:02 UTC) #2

Peter.Rybin

https://codereview.chromium.org/23264015/diff/5001/src/runtime.cc File src/runtime.cc (right): https://codereview.chromium.org/23264015/diff/5001/src/runtime.cc#newcode12022 src/runtime.cc:12022: if (frame_it.done()) { On 2013/08/26 13:52:02, Yang wrote: > ...

7 years, 3 months ago (2013-08-31 16:58:07 UTC) #3

Peter.Rybin

7 years, 3 months ago (2013-09-02 12:25:00 UTC) #4

Message was sent while issue was closed.

Committed patchset #4 manually as r16472 (presubmit successful).

Expand Messages | Collapse Messages