Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 23264011: Quota view in Resources pannel.

Created:
7 years, 4 months ago by SeRya
Modified:
6 years, 5 months ago
Reviewers:
aandrey
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

Quota view in Resources pannel. Depends on https://codereview.chromium.org/23240002/ BUG=281252

Patch Set 1 #

Patch Set 2 : #

Total comments: 6

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+305 lines, -0 lines) Patch
M LayoutTests/inspector/resources/blink-fs.js View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/inspector/InspectorPageAgent.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/inspector/InspectorPageAgent.cpp View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M Source/devtools/devtools.gyp View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
A Source/devtools/front_end/Images/quota.png View Binary file 0 comments Download
A Source/devtools/front_end/QuotaView.js View 1 2 1 chunk +132 lines, -0 lines 0 comments Download
M Source/devtools/front_end/ResourcesPanel.js View 1 2 3 6 chunks +108 lines, -0 lines 0 comments Download
M Source/devtools/front_end/resourcesPanel.css View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M Source/devtools/protocol.json View 1 2 3 2 chunks +50 lines, -0 lines 0 comments Download
M Source/devtools/scripts/compile_frontend.py View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
pfeldman
https://codereview.chromium.org/23264011/diff/4001/Source/devtools/protocol.json File Source/devtools/protocol.json (right): https://codereview.chromium.org/23264011/diff/4001/Source/devtools/protocol.json#newcode200 Source/devtools/protocol.json:200: "id": "Quota", I'd rather have a structure: Quota: { ...
7 years, 3 months ago (2013-09-19 17:37:31 UTC) #1
aandrey
https://codereview.chromium.org/23264011/diff/4001/Source/devtools/front_end/QuotaView.js File Source/devtools/front_end/QuotaView.js (right): https://codereview.chromium.org/23264011/diff/4001/Source/devtools/front_end/QuotaView.js#newcode66 Source/devtools/front_end/QuotaView.js:66: var columns = [ check error? https://codereview.chromium.org/23264011/diff/4001/Source/devtools/front_end/QuotaView.js#newcode99 Source/devtools/front_end/QuotaView.js:99: PageAgent.queryUsageAndQuota(this.securityOrigin, ...
7 years, 3 months ago (2013-09-20 08:31:58 UTC) #2
SeRya
Screenshot is available here: https://docs.google.com/file/d/0B3SVkF4M472XUVRTWlhfV1p3LTg/edit?usp=sharing https://codereview.chromium.org/23264011/diff/4001/Source/devtools/front_end/QuotaView.js File Source/devtools/front_end/QuotaView.js (right): https://codereview.chromium.org/23264011/diff/4001/Source/devtools/front_end/QuotaView.js#newcode66 Source/devtools/front_end/QuotaView.js:66: var columns = [ ...
7 years, 2 months ago (2013-09-27 13:31:01 UTC) #3
pfeldman
Is there a screenshot?
7 years, 2 months ago (2013-10-17 17:22:45 UTC) #4
SeRya
On 2013/10/17 17:22:45, pfeldman wrote: > Is there a screenshot? Sure. https://docs.google.com/file/d/0B3SVkF4M472XUVRTWlhfV1p3LTg/edit?usp=sharing
7 years, 2 months ago (2013-10-21 10:55:10 UTC) #5
vsevik
On 2013/10/21 10:55:10, SeRya wrote: > On 2013/10/17 17:22:45, pfeldman wrote: > > Is there ...
7 years, 1 month ago (2013-10-25 06:51:30 UTC) #6
SeRya
New patchset uploaded. Updated screenshot is here: https://drive.google.com/file/d/0B3SVkF4M472XRXQ0WmR6bHh6UHc/edit?usp=sharing
7 years, 1 month ago (2013-10-25 10:56:18 UTC) #7
aandrey
Do we want to continue this work?
6 years, 5 months ago (2014-07-02 11:11:45 UTC) #8
pfeldman
It is lower priority than other things we are busy with. But it addresses one ...
6 years, 5 months ago (2014-07-02 18:30:19 UTC) #9
lushnikov
6 years, 5 months ago (2014-07-03 12:35:29 UTC) #10
On 2014/07/02 18:30:19, pfeldman wrote:
> It is lower priority than other things we are busy with. But it addresses one
of
> the important mobile scenarios, so we might want to resume it at some point.
We
> can remove ourselves from reviewers list for now.

FYI: no need to change blink-fs.js file

Powered by Google App Engine
This is Rietveld 408576698