Revert of Refactor X11ForeignWindowManager

Revert of Refactor X11ForeignWindowManager (patchset #8 id:130001 of https://codereview.chromium.org/2313033002/ )

Reason for revert:
Broke the build!

BUG=645713
Original issue's description:
> This CL renames XForeignWindowManager to XWindowEventManager since it will be
> used on local windows now.  Get rid of OnWindowDestroyed since this will be
> used by the XWindowCache for windows other than top-level windows as well.
> Finally, refactor the old Request implementation to use a Mask instead.
>
> This is needed by the XWindowCache which will select events on all windows, and
> therefore needs to know which masks we've already selected on Chrome windows.
>
> This will be the first in the line of 3 CLs.
> 1. Refactor X11ForeignWindowManager
> 2. Update Chrome code to use the XWindowManager instead of calling XSelectInput
> manually
> 3. Add a PRESUBMIT check to make sure CWEventMask, XSelectInput, or
> XCB_CW_EVENT_MASK is not added to new code.
>
> BUG=634084
>
> Committed: https://crrev.com/5c04e8aa6732cca81e518dacf06c48398426b415
> Cr-Commit-Position: refs/heads/master@{#417793}

TBR=erg@chromium.org,derat@chromium.org,thestig@chromium.org,thomasanderson@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=634084
Committed: https://crrev.com/72dc016bf78ba8512d9fb2c372eef8575510e710
Cr-Commit-Position: refs/heads/master@{#417798}

[dmurph, 2016-09-10 02:04:09]

The CQ bit was checked by dmurph@chromium.org

[dmurph, 2016-09-10 02:04:10]

Created Revert of Refactor X11ForeignWindowManager

[commit-bot: I haz the power, 2016-09-10 02:04:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-10 02:05:16]

Description was changed from

==========
Revert of Refactor X11ForeignWindowManager (patchset #8 id:130001 of
https://codereview.chromium.org/2313033002/ )

Reason for revert:
Broke the build!

BUG=645713

Original issue's description:
> This CL renames XForeignWindowManager to XWindowEventManager since it will be
> used on local windows now.  Get rid of OnWindowDestroyed since this will be
> used by the XWindowCache for windows other than top-level windows as well.
> Finally, refactor the old Request implementation to use a Mask instead.
> 
> This is needed by the XWindowCache which will select events on all windows,
and
> therefore needs to know which masks we've already selected on Chrome windows.
> 
> This will be the first in the line of 3 CLs.
> 1. Refactor X11ForeignWindowManager
> 2. Update Chrome code to use the XWindowManager instead of calling
XSelectInput
> manually
> 3. Add a PRESUBMIT check to make sure CWEventMask, XSelectInput, or
> XCB_CW_EVENT_MASK is not added to new code.
> 
> BUG=634084
> 
> Committed: https://crrev.com/5c04e8aa6732cca81e518dacf06c48398426b415
> Cr-Commit-Position: refs/heads/master@{#417793}

TBR=erg@chromium.org,derat@chromium.org,thestig@chromium.org,thomasanderson@g...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=634084
==========

to

==========
Revert of Refactor X11ForeignWindowManager (patchset #8 id:130001 of
https://codereview.chromium.org/2313033002/ )

Reason for revert:
Broke the build!

BUG=645713

Original issue's description:
> This CL renames XForeignWindowManager to XWindowEventManager since it will be
> used on local windows now.  Get rid of OnWindowDestroyed since this will be
> used by the XWindowCache for windows other than top-level windows as well.
> Finally, refactor the old Request implementation to use a Mask instead.
> 
> This is needed by the XWindowCache which will select events on all windows,
and
> therefore needs to know which masks we've already selected on Chrome windows.
> 
> This will be the first in the line of 3 CLs.
> 1. Refactor X11ForeignWindowManager
> 2. Update Chrome code to use the XWindowManager instead of calling
XSelectInput
> manually
> 3. Add a PRESUBMIT check to make sure CWEventMask, XSelectInput, or
> XCB_CW_EVENT_MASK is not added to new code.
> 
> BUG=634084
> 
> Committed: https://crrev.com/5c04e8aa6732cca81e518dacf06c48398426b415
> Cr-Commit-Position: refs/heads/master@{#417793}

TBR=erg@chromium.org,derat@chromium.org,thestig@chromium.org,thomasanderson@g...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=634084
==========

[commit-bot: I haz the power, 2016-09-10 02:05:17]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-10 02:06:45]

Description was changed from

==========
Revert of Refactor X11ForeignWindowManager (patchset #8 id:130001 of
https://codereview.chromium.org/2313033002/ )

Reason for revert:
Broke the build!

BUG=645713

Original issue's description:
> This CL renames XForeignWindowManager to XWindowEventManager since it will be
> used on local windows now.  Get rid of OnWindowDestroyed since this will be
> used by the XWindowCache for windows other than top-level windows as well.
> Finally, refactor the old Request implementation to use a Mask instead.
> 
> This is needed by the XWindowCache which will select events on all windows,
and
> therefore needs to know which masks we've already selected on Chrome windows.
> 
> This will be the first in the line of 3 CLs.
> 1. Refactor X11ForeignWindowManager
> 2. Update Chrome code to use the XWindowManager instead of calling
XSelectInput
> manually
> 3. Add a PRESUBMIT check to make sure CWEventMask, XSelectInput, or
> XCB_CW_EVENT_MASK is not added to new code.
> 
> BUG=634084
> 
> Committed: https://crrev.com/5c04e8aa6732cca81e518dacf06c48398426b415
> Cr-Commit-Position: refs/heads/master@{#417793}

TBR=erg@chromium.org,derat@chromium.org,thestig@chromium.org,thomasanderson@g...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=634084
==========

to

==========
Revert of Refactor X11ForeignWindowManager (patchset #8 id:130001 of
https://codereview.chromium.org/2313033002/ )

Reason for revert:
Broke the build!

BUG=645713

Original issue's description:
> This CL renames XForeignWindowManager to XWindowEventManager since it will be
> used on local windows now.  Get rid of OnWindowDestroyed since this will be
> used by the XWindowCache for windows other than top-level windows as well.
> Finally, refactor the old Request implementation to use a Mask instead.
>
> This is needed by the XWindowCache which will select events on all windows,
and
> therefore needs to know which masks we've already selected on Chrome windows.
>
> This will be the first in the line of 3 CLs.
> 1. Refactor X11ForeignWindowManager
> 2. Update Chrome code to use the XWindowManager instead of calling
XSelectInput
> manually
> 3. Add a PRESUBMIT check to make sure CWEventMask, XSelectInput, or
> XCB_CW_EVENT_MASK is not added to new code.
>
> BUG=634084
>
> Committed: https://crrev.com/5c04e8aa6732cca81e518dacf06c48398426b415
> Cr-Commit-Position: refs/heads/master@{#417793}

TBR=erg@chromium.org,derat@chromium.org,thestig@chromium.org,thomasanderson@g...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=634084

Committed: https://crrev.com/72dc016bf78ba8512d9fb2c372eef8575510e710
Cr-Commit-Position: refs/heads/master@{#417798}
==========

[commit-bot: I haz the power, 2016-09-10 02:06:46]

Patchset 1 (id:??) landed as
https://crrev.com/72dc016bf78ba8512d9fb2c372eef8575510e710
Cr-Commit-Position: refs/heads/master@{#417798}

[Lei Zhang, 2016-09-10 02:10:57]

What broke exactly? We need context when reverting.

Are you sure this is the problem and not r417790?

[dmurph, 2016-09-10 03:38:57]

Crbug.com/645713

Not super sure, but according to the Sheriff bot that was the only cl in
that build

On Fri, Sep 9, 2016, 7:11 PM <thestig@chromium.org> wrote:

> What broke exactly? We need context when reverting.
>
> Are you sure this is the problem and not r417790?
>
> https://codereview.chromium.org/2326223002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.