Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2326163002:
Make hspace/vspace unsigned long in idl (Closed)
DescriptionMake hspace/vspace unsigned long in idl
Make hspace/vspace unsigned long in idl of HTMLImageElement
and HTMLObjectElement in accordance with the spec:
https://html.spec.whatwg.org/#HTMLImageElement-partial
https://html.spec.whatwg.org/#HTMLObjectElement-partial
Behavior matches WebKit and Firefox.
BUG=460722
Committed: https://crrev.com/a72c076b3a74cda96a6572f47a19a3a8f7c964a9
Cr-Commit-Position: refs/heads/master@{#420800}
Patch Set 1 #Patch Set 2 : Also update HTMLObjectElement.idl #Patch Set 3 : V3 #
Messages
Total messages: 19 (10 generated)
Description was changed from ========== hspace WIP BUG= ========== to ========== Make vspace/hspace unsigned long in idl Make vspace/hspace unsigned long in idl of HTMLImageElement and HTMLObjectElement : https://html.spec.whatwg.org/#HTMLImageElement-partial https://html.spec.whatwg.org/#HTMLObjectElement-partial BUG=460722 ==========
Description was changed from ========== Make vspace/hspace unsigned long in idl Make vspace/hspace unsigned long in idl of HTMLImageElement and HTMLObjectElement : https://html.spec.whatwg.org/#HTMLImageElement-partial https://html.spec.whatwg.org/#HTMLObjectElement-partial BUG=460722 ========== to ========== Make vspace/hspace unsigned long in idl Make vspace/hspace unsigned long in idl of HTMLImageElement and HTMLObjectElement to sync with the spec: https://html.spec.whatwg.org/#HTMLImageElement-partial https://html.spec.whatwg.org/#HTMLObjectElement-partial BUG=460722 ==========
Description was changed from ========== Make vspace/hspace unsigned long in idl Make vspace/hspace unsigned long in idl of HTMLImageElement and HTMLObjectElement to sync with the spec: https://html.spec.whatwg.org/#HTMLImageElement-partial https://html.spec.whatwg.org/#HTMLObjectElement-partial BUG=460722 ========== to ========== Make hspace/vspace unsigned long in idl Make hspace/vspace unsigned long in idl of HTMLImageElement and HTMLObjectElement in accordance with the spec: https://html.spec.whatwg.org/#HTMLImageElement-partial https://html.spec.whatwg.org/#HTMLObjectElement-partial BUG=460722 ==========
rob.buis@samsung.com changed reviewers: + foolip@chromium.org
PTAL. Notice that this improves html/dom/reflection-embedded.html score but we can't enable that one (yet) because of crbug.com/490939.
LGTM I see this is unsigned long in Gecko and still long in WebKit. Edge is funny and throws an exception when setting to anything outside the range [0, 2147483647]. Since this is just about edge cases, just going along with the spec and wpt seems OK.
Hi Philip, On 2016/09/23 21:11:04, foolip wrote: > LGTM Thanks! > I see this is unsigned long in Gecko and still long in WebKit. My WebKit checkout of today shows they use unsigned long: Source/WebCore/html/HTMLObjectElement.idl: [Reflect] attribute unsigned long vspace; Source/WebCore/html/HTMLImageElement.idl: [Reflect] attribute unsigned long vspace; But maybe you were leaking at an official release. Anyway I'll add a blurb about compatibility to the commit log :)
Description was changed from ========== Make hspace/vspace unsigned long in idl Make hspace/vspace unsigned long in idl of HTMLImageElement and HTMLObjectElement in accordance with the spec: https://html.spec.whatwg.org/#HTMLImageElement-partial https://html.spec.whatwg.org/#HTMLObjectElement-partial BUG=460722 ========== to ========== Make hspace/vspace unsigned long in idl Make hspace/vspace unsigned long in idl of HTMLImageElement and HTMLObjectElement in accordance with the spec: https://html.spec.whatwg.org/#HTMLImageElement-partial https://html.spec.whatwg.org/#HTMLObjectElement-partial Behavior matches WebKit and Firefox. BUG=460722 ==========
The CQ bit was checked by rob.buis@samsung.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2016/09/23 21:32:56, rwlbuis wrote: > Hi Philip, > > On 2016/09/23 21:11:04, foolip wrote: > > LGTM > > Thanks! > > > I see this is unsigned long in Gecko and still long in WebKit. > > My WebKit checkout of today shows they use unsigned long: > Source/WebCore/html/HTMLObjectElement.idl: [Reflect] attribute unsigned long > vspace; > Source/WebCore/html/HTMLImageElement.idl: [Reflect] attribute unsigned long > vspace; > > But maybe you were leaking at an official release. Anyway I'll add a blurb about > compatibility to the commit log :) I had a local checkout, turns out it was a few months old.
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by rob.buis@samsung.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Make hspace/vspace unsigned long in idl Make hspace/vspace unsigned long in idl of HTMLImageElement and HTMLObjectElement in accordance with the spec: https://html.spec.whatwg.org/#HTMLImageElement-partial https://html.spec.whatwg.org/#HTMLObjectElement-partial Behavior matches WebKit and Firefox. BUG=460722 ========== to ========== Make hspace/vspace unsigned long in idl Make hspace/vspace unsigned long in idl of HTMLImageElement and HTMLObjectElement in accordance with the spec: https://html.spec.whatwg.org/#HTMLImageElement-partial https://html.spec.whatwg.org/#HTMLObjectElement-partial Behavior matches WebKit and Firefox. BUG=460722 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Make hspace/vspace unsigned long in idl Make hspace/vspace unsigned long in idl of HTMLImageElement and HTMLObjectElement in accordance with the spec: https://html.spec.whatwg.org/#HTMLImageElement-partial https://html.spec.whatwg.org/#HTMLObjectElement-partial Behavior matches WebKit and Firefox. BUG=460722 ========== to ========== Make hspace/vspace unsigned long in idl Make hspace/vspace unsigned long in idl of HTMLImageElement and HTMLObjectElement in accordance with the spec: https://html.spec.whatwg.org/#HTMLImageElement-partial https://html.spec.whatwg.org/#HTMLObjectElement-partial Behavior matches WebKit and Firefox. BUG=460722 Committed: https://crrev.com/a72c076b3a74cda96a6572f47a19a3a8f7c964a9 Cr-Commit-Position: refs/heads/master@{#420800} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/a72c076b3a74cda96a6572f47a19a3a8f7c964a9 Cr-Commit-Position: refs/heads/master@{#420800} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
