Rename referrerPolicy() methods to getReferrerPolicy().

Rename referrerPolicy() methods to getReferrerPolicy().

The rename is needed to avoid a naming collision after changing from
Blink to Chromium naming style.  Right now we have a |ReferrerPolicy|
type and quite a few |referrerPolicy| methods (differing only by case of
the first character); after a naive rename by the
rewrite_to_chrome_style tool we would end up with |ReferrerPolicy| being
the name of both the type and the method (with both living in the same
namespace).

Prepending a "get" prefix to the name of the accessor method is the
workaround that fits into the guidance on the recommended
post-Blink-to-Chromium-rename style suggested by esprehn@ in
https://crbug.com/582312#c17:
- Getters favor not using "Get", ex. FirstChild()
- Unless the type name conflicts, in which case you can either rename
  the type if it's easy and makes sense, or add "Get", ex. GetContext().

BUG=582312
TBR=gavinp@chromium.org, nasko@chromium.org

Committed: https://crrev.com/2fdf8d1a4a83a2108cebc25c140962346bc0c2e6
Cr-Commit-Position: refs/heads/master@{#435958}

[Łukasz Anforowicz, 2016-09-10 00:09:48]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-10 00:10:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Łukasz Anforowicz, 2016-09-10 00:10:44]

Description was changed from

==========
Rename referrerPolicy() methods to getReferrerPolicy().

The rename is needed to avoid a naming collision after changing from
Blink to Chromium naming style.  Right now we have a |ReferrerPolicy|
type and quite a few |referrerPolicy| methods (differing only by case of
the first character); after a naive rename by the
rewrite_to_chrome_style tool we would end up with |ReferrerPolicy| being
the name of both the type and the method (with both living in the same
namespace).

Prepending a "get" prefix to the name of the accessor method is the
workaround that fits into the guidance on the recommended
post-Blink-to-Chromium-rename style suggested by esprehn@ in
https://crbug.com/582312#c17:
- Getters favor not using "Get", ex. FirstChild()
- Unless the type name conflicts, in which case you can either rename
  the type if it's easy and makes sense, or add "Get", ex. GetContext().

BUG=582312
==========

to

==========
Rename referrerPolicy() methods to getReferrerPolicy().

The rename is needed to avoid a naming collision after changing from
Blink to Chromium naming style.  Right now we have a |ReferrerPolicy|
type and quite a few |referrerPolicy| methods (differing only by case of
the first character); after a naive rename by the
rewrite_to_chrome_style tool we would end up with |ReferrerPolicy| being
the name of both the type and the method (with both living in the same
namespace).

Prepending a "get" prefix to the name of the accessor method is the
workaround that fits into the guidance on the recommended
post-Blink-to-Chromium-rename style suggested by esprehn@ in
https://crbug.com/582312#c17:
- Getters favor not using "Get", ex. FirstChild()
- Unless the type name conflicts, in which case you can either rename
  the type if it's easy and makes sense, or add "Get", ex. GetContext().

BUG=582312
==========

[Łukasz Anforowicz, 2016-09-10 00:10:44]

lukasza@chromium.org changed reviewers:
+ esprehn@chromium.org

[commit-bot: I haz the power, 2016-09-10 00:26:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-10 00:26:38]

Dry run: Try jobs failed on following builders:
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Łukasz Anforowicz, 2016-12-02 01:18:22]

lukasza@chromium.org changed reviewers:
+ tkent@chromium.org
- esprehn@chromium.org

[Łukasz Anforowicz, 2016-12-02 01:18:23]

tkent@, could you PTAL?

[tkent, 2016-12-02 01:30:41]

lgtm

[Łukasz Anforowicz, 2016-12-02 15:11:56]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-02 15:12:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Łukasz Anforowicz, 2016-12-02 15:46:56]

Description was changed from

==========
Rename referrerPolicy() methods to getReferrerPolicy().

The rename is needed to avoid a naming collision after changing from
Blink to Chromium naming style.  Right now we have a |ReferrerPolicy|
type and quite a few |referrerPolicy| methods (differing only by case of
the first character); after a naive rename by the
rewrite_to_chrome_style tool we would end up with |ReferrerPolicy| being
the name of both the type and the method (with both living in the same
namespace).

Prepending a "get" prefix to the name of the accessor method is the
workaround that fits into the guidance on the recommended
post-Blink-to-Chromium-rename style suggested by esprehn@ in
https://crbug.com/582312#c17:
- Getters favor not using "Get", ex. FirstChild()
- Unless the type name conflicts, in which case you can either rename
  the type if it's easy and makes sense, or add "Get", ex. GetContext().

BUG=582312
==========

to

==========
Rename referrerPolicy() methods to getReferrerPolicy().

The rename is needed to avoid a naming collision after changing from
Blink to Chromium naming style.  Right now we have a |ReferrerPolicy|
type and quite a few |referrerPolicy| methods (differing only by case of
the first character); after a naive rename by the
rewrite_to_chrome_style tool we would end up with |ReferrerPolicy| being
the name of both the type and the method (with both living in the same
namespace).

Prepending a "get" prefix to the name of the accessor method is the
workaround that fits into the guidance on the recommended
post-Blink-to-Chromium-rename style suggested by esprehn@ in
https://crbug.com/582312#c17:
- Getters favor not using "Get", ex. FirstChild()
- Unless the type name conflicts, in which case you can either rename
  the type if it's easy and makes sense, or add "Get", ex. GetContext().

BUG=582312
TBR=gavinp@chromium.org, nasko@chromium.org
==========

[Łukasz Anforowicz, 2016-12-02 15:49:47]

lukasza@chromium.org changed reviewers:
+ gavinp@chromium.org, nasko@chromium.org

[Łukasz Anforowicz, 2016-12-02 15:49:48]

gavinp@, nasko@ - I plan to TBR you on this mostly mechanical CL that happens to
touch //chrome/renderer/prerender and //content.

[commit-bot: I haz the power, 2016-12-02 16:16:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 16:16:58]

Dry run: This issue passed the CQ dry run.

[Łukasz Anforowicz, 2016-12-02 16:55:07]

The CQ bit was checked by lukasza@chromium.org

[commit-bot: I haz the power, 2016-12-02 16:55:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 17:00:09]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480697707277290,
"parent_rev": "97f5ead20a30186e15f46eb4ba12b2e4417ee7f9", "commit_rev":
"db78f902911f9421f75ab5a37d830e54f227f31d"}

[commit-bot: I haz the power, 2016-12-02 17:00:39]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-02 17:02:46]

Description was changed from

==========
Rename referrerPolicy() methods to getReferrerPolicy().

The rename is needed to avoid a naming collision after changing from
Blink to Chromium naming style.  Right now we have a |ReferrerPolicy|
type and quite a few |referrerPolicy| methods (differing only by case of
the first character); after a naive rename by the
rewrite_to_chrome_style tool we would end up with |ReferrerPolicy| being
the name of both the type and the method (with both living in the same
namespace).

Prepending a "get" prefix to the name of the accessor method is the
workaround that fits into the guidance on the recommended
post-Blink-to-Chromium-rename style suggested by esprehn@ in
https://crbug.com/582312#c17:
- Getters favor not using "Get", ex. FirstChild()
- Unless the type name conflicts, in which case you can either rename
  the type if it's easy and makes sense, or add "Get", ex. GetContext().

BUG=582312
TBR=gavinp@chromium.org, nasko@chromium.org
==========

to

==========
Rename referrerPolicy() methods to getReferrerPolicy().

The rename is needed to avoid a naming collision after changing from
Blink to Chromium naming style.  Right now we have a |ReferrerPolicy|
type and quite a few |referrerPolicy| methods (differing only by case of
the first character); after a naive rename by the
rewrite_to_chrome_style tool we would end up with |ReferrerPolicy| being
the name of both the type and the method (with both living in the same
namespace).

Prepending a "get" prefix to the name of the accessor method is the
workaround that fits into the guidance on the recommended
post-Blink-to-Chromium-rename style suggested by esprehn@ in
https://crbug.com/582312#c17:
- Getters favor not using "Get", ex. FirstChild()
- Unless the type name conflicts, in which case you can either rename
  the type if it's easy and makes sense, or add "Get", ex. GetContext().

BUG=582312
TBR=gavinp@chromium.org, nasko@chromium.org

Committed: https://crrev.com/2fdf8d1a4a83a2108cebc25c140962346bc0c2e6
Cr-Commit-Position: refs/heads/master@{#435958}
==========

[commit-bot: I haz the power, 2016-12-02 17:02:47]

Patchset 2 (id:??) landed as
https://crrev.com/2fdf8d1a4a83a2108cebc25c140962346bc0c2e6
Cr-Commit-Position: refs/heads/master@{#435958}

[nasko, 2016-12-02 21:48:41]

content/ LGTM