Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issue 2326153002: Revert of Fix kLargestDrawQuadSize (Closed)

Created:
4 years, 3 months ago by dmurph
Modified:
4 years, 3 months ago
Reviewers:
danakj, hubbe
CC:
chromium-reviews, cc-bugs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix kLargestDrawQuadSize (patchset #1 id:1 of https://codereview.chromium.org/2328433005/ ) Reason for revert: Reverting, I think this caused buffer size issues https://bugs.chromium.org/p/chromium/issues/detail?id=645634 BUG=645634 Original issue's description: > Fix kLargestDrawQuadSize > > This should work, but triggered a bug in the past. > Trying again, if nothing else I'll find out what problem was triggered. > > BUG=644443 > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel > > Committed: https://crrev.com/e099ceca4f5145bf650a2293807c585cc717121f > Cr-Commit-Position: refs/heads/master@{#417646} TBR=danakj@chromium.org,hubbe@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=644443 Committed: https://crrev.com/208f4013ba1cab8f188beb508915c49abe5ebdf7 Cr-Commit-Position: refs/heads/master@{#417708}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M cc/quads/draw_quad_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M cc/quads/largest_draw_quad.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
dmurph
Created Revert of Fix kLargestDrawQuadSize
4 years, 3 months ago (2016-09-09 21:00:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2326153002/1
4 years, 3 months ago (2016-09-09 21:01:09 UTC) #3
commit-bot: I haz the power
Failed to apply the patch. On branch working_branch Your branch is up-to-date with 'origin/refs/pending/heads/master'. nothing ...
4 years, 3 months ago (2016-09-09 21:03:37 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 21:04:12 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/208f4013ba1cab8f188beb508915c49abe5ebdf7
Cr-Commit-Position: refs/heads/master@{#417708}

Powered by Google App Engine
This is Rietveld 408576698