Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Unified Diff: third_party/WebKit/Source/core/BUILD.gn

Issue 2326143002: Enable incremental linking for blink_core, 32-bit (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/win/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/BUILD.gn
diff --git a/third_party/WebKit/Source/core/BUILD.gn b/third_party/WebKit/Source/core/BUILD.gn
index 49fc5a105cb7afd332895cae45522a88c79d5c99..9a542ba9a20efd46a15b17c6139c0244b87648aa 100644
--- a/third_party/WebKit/Source/core/BUILD.gn
+++ b/third_party/WebKit/Source/core/BUILD.gn
@@ -177,9 +177,11 @@ component("core") {
"//third_party/WebKit/Source/core/xmlhttprequest",
]
- if (is_win && is_debug && is_component_build) {
- # Incremental linking doesn't work on this target in debug mode, even
- # with symbol_level=1.
+ if (is_win && is_debug && is_component_build && current_cpu == "x64") {
+ # Incremental linking doesn't work on this target in debug mode for
+ # 64-bit builds - the .ilk file gets too large and the incremental
+ # link silently fails. Therefore 32-bit builds should be used for
+ # fastest incremental build performance.
configs -= [ "//build/config/win:default_incremental_linking" ]
configs += [ "//build/config/win:no_incremental_linking" ]
}
« no previous file with comments | « build/config/win/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698