Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 2326063005: Use the device name instead of "device" in enrollment success messages. (Closed)

Created:
4 years, 3 months ago by The one and only Dr. Crash
Modified:
4 years, 3 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use the device name instead of "device" in enrollment success messages. BUG=645731 TEST=manual CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/909dce100807ef360e146c5541afffa1938cb956 Cr-Commit-Position: refs/heads/master@{#418065}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -12 lines) Patch
M chrome/app/chromeos_strings.grdp View 3 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_screen_oauth_enrollment.js View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.cc View 6 chunks +14 lines, -4 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
The one and only Dr. Crash
4 years, 3 months ago (2016-09-10 05:32:06 UTC) #2
The one and only Dr. Crash
Vetted with UX. The UX should eventually change from these weird-looking "success" screens that are ...
4 years, 3 months ago (2016-09-12 19:38:38 UTC) #8
xiyuan
lgtm
4 years, 3 months ago (2016-09-12 19:48:47 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2326063005/1
4 years, 3 months ago (2016-09-12 20:17:08 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: closure_compilation on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compilation/builds/2597)
4 years, 3 months ago (2016-09-12 20:25:59 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2326063005/1
4 years, 3 months ago (2016-09-12 21:44:52 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-12 21:51:12 UTC) #16
commit-bot: I haz the power
4 years, 3 months ago (2016-09-12 21:53:29 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/909dce100807ef360e146c5541afffa1938cb956
Cr-Commit-Position: refs/heads/master@{#418065}

Powered by Google App Engine
This is Rietveld 408576698