Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2326063004:
Manually roll src/third_party/catapult/ da6d44e4a..c0b988891 (3 commits). (Closed)
DescriptionManually roll src/third_party/catapult/ da6d44e4a..c0b988891 (3 commits).
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/da6d44e4a2a5..c0b988891fd1
$ git log da6d44e4a..c0b988891 --date=short --no-merges --format='%ad %ae %s'
2016-09-09 erikchen Add a new cpu time TBMv2 system health metric.
2016-09-09 nednguyen Update the lock operation in cloud_storage with better implementation using py_utils.lock
2016-09-09 rnephew [BattOr] Kill BattOr shell if there is a problem with communicating during clock sync.
BUG=640312, 637904, 645106, 645720
TBR=catapult-sheriff@chromium.org, jbudorick@chromium.org
Committed: https://crrev.com/c4b1e75d9334ca63343d5e44768c246d796c8386
Cr-Commit-Position: refs/heads/master@{#417833}
Patch Set 1 #Patch Set 2 : Add cloud_storage_global_lock #
Total comments: 2
Messages
Total messages: 19 (7 generated)
Description was changed from ========== Manually roll src/third_party/catapult/ da6d44e4a..c0b988891 (3 commits). https://chromium.googlesource.com/external/github.com/catapult-project/catapu... $ git log da6d44e4a..c0b988891 --date=short --no-merges --format='%ad %ae %s' 2016-09-09 erikchen Add a new cpu time TBMv2 system health metric. 2016-09-09 nednguyen Update the lock operation in cloud_storage with better implementation using py_utils.lock 2016-09-09 rnephew [BattOr] Kill BattOr shell if there is a problem with communicating during clock sync. BUG=640312,637904,645106 TBR=catapult-sheriff@chromium.org ========== to ========== Manually roll src/third_party/catapult/ da6d44e4a..c0b988891 (3 commits). https://chromium.googlesource.com/external/github.com/catapult-project/catapu... $ git log da6d44e4a..c0b988891 --date=short --no-merges --format='%ad %ae %s' 2016-09-09 erikchen Add a new cpu time TBMv2 system health metric. 2016-09-09 nednguyen Update the lock operation in cloud_storage with better implementation using py_utils.lock 2016-09-09 rnephew [BattOr] Kill BattOr shell if there is a problem with communicating during clock sync. BUG=640312,637904,645106,645720 TBR=catapult-sheriff@chromium.org, jbudorick@chromium.org ==========
The CQ bit was checked by nednguyen@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by nednguyen@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2326063004/diff/20001/build/android/test_runn... File build/android/test_runner.pydeps (right): https://codereview.chromium.org/2326063004/diff/20001/build/android/test_runn... build/android/test_runner.pydeps:5: ../../third_party/catapult/common/py_utils/py_utils/cloud_storage_global_lock We need to figure out what to do with this :-/
Message was sent while issue was closed.
Description was changed from ========== Manually roll src/third_party/catapult/ da6d44e4a..c0b988891 (3 commits). https://chromium.googlesource.com/external/github.com/catapult-project/catapu... $ git log da6d44e4a..c0b988891 --date=short --no-merges --format='%ad %ae %s' 2016-09-09 erikchen Add a new cpu time TBMv2 system health metric. 2016-09-09 nednguyen Update the lock operation in cloud_storage with better implementation using py_utils.lock 2016-09-09 rnephew [BattOr] Kill BattOr shell if there is a problem with communicating during clock sync. BUG=640312,637904,645106,645720 TBR=catapult-sheriff@chromium.org, jbudorick@chromium.org ========== to ========== Manually roll src/third_party/catapult/ da6d44e4a..c0b988891 (3 commits). https://chromium.googlesource.com/external/github.com/catapult-project/catapu... $ git log da6d44e4a..c0b988891 --date=short --no-merges --format='%ad %ae %s' 2016-09-09 erikchen Add a new cpu time TBMv2 system health metric. 2016-09-09 nednguyen Update the lock operation in cloud_storage with better implementation using py_utils.lock 2016-09-09 rnephew [BattOr] Kill BattOr shell if there is a problem with communicating during clock sync. BUG=640312,637904,645106,645720 TBR=catapult-sheriff@chromium.org, jbudorick@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Manually roll src/third_party/catapult/ da6d44e4a..c0b988891 (3 commits). https://chromium.googlesource.com/external/github.com/catapult-project/catapu... $ git log da6d44e4a..c0b988891 --date=short --no-merges --format='%ad %ae %s' 2016-09-09 erikchen Add a new cpu time TBMv2 system health metric. 2016-09-09 nednguyen Update the lock operation in cloud_storage with better implementation using py_utils.lock 2016-09-09 rnephew [BattOr] Kill BattOr shell if there is a problem with communicating during clock sync. BUG=640312,637904,645106,645720 TBR=catapult-sheriff@chromium.org, jbudorick@chromium.org ========== to ========== Manually roll src/third_party/catapult/ da6d44e4a..c0b988891 (3 commits). https://chromium.googlesource.com/external/github.com/catapult-project/catapu... $ git log da6d44e4a..c0b988891 --date=short --no-merges --format='%ad %ae %s' 2016-09-09 erikchen Add a new cpu time TBMv2 system health metric. 2016-09-09 nednguyen Update the lock operation in cloud_storage with better implementation using py_utils.lock 2016-09-09 rnephew [BattOr] Kill BattOr shell if there is a problem with communicating during clock sync. BUG=640312,637904,645106,645720 TBR=catapult-sheriff@chromium.org, jbudorick@chromium.org Committed: https://crrev.com/c4b1e75d9334ca63343d5e44768c246d796c8386 Cr-Commit-Position: refs/heads/master@{#417833} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/c4b1e75d9334ca63343d5e44768c246d796c8386 Cr-Commit-Position: refs/heads/master@{#417833}
Message was sent while issue was closed.
jbudorick@chromium.org changed reviewers: + jbudorick@chromium.org
Message was sent while issue was closed.
https://codereview.chromium.org/2326063004/diff/20001/build/android/test_runn... File build/android/test_runner.pydeps (right): https://codereview.chromium.org/2326063004/diff/20001/build/android/test_runn... build/android/test_runner.pydeps:5: ../../third_party/catapult/common/py_utils/py_utils/cloud_storage_global_lock On 2016/09/10 11:14:50, nednguyen wrote: > We need to figure out what to do with this :-/ I'm not sure this was right.
Message was sent while issue was closed.
On 2016/09/12 20:14:54, jbudorick wrote: > https://codereview.chromium.org/2326063004/diff/20001/build/android/test_runn... > File build/android/test_runner.pydeps (right): > > https://codereview.chromium.org/2326063004/diff/20001/build/android/test_runn... > build/android/test_runner.pydeps:5: > ../../third_party/catapult/common/py_utils/py_utils/cloud_storage_global_lock > On 2016/09/10 11:14:50, nednguyen wrote: > > We need to figure out what to do with this :-/ > > I'm not sure this was right. I think so either, but how should we proceed? :-/
Message was sent while issue was closed.
On 2016/09/12 20:23:37, nednguyen wrote: > On 2016/09/12 20:14:54, jbudorick wrote: > > > https://codereview.chromium.org/2326063004/diff/20001/build/android/test_runn... > > File build/android/test_runner.pydeps (right): > > > > > https://codereview.chromium.org/2326063004/diff/20001/build/android/test_runn... > > build/android/test_runner.pydeps:5: > > ../../third_party/catapult/common/py_utils/py_utils/cloud_storage_global_lock > > On 2016/09/10 11:14:50, nednguyen wrote: > > > We need to figure out what to do with this :-/ > > > > I'm not sure this was right. > > I think so either, but how should we proceed? :-/ Probably let the ANGLE roll go in w/ the change to pydeps. Please don't TBR changes to this file, particularly on a Saturday.
Message was sent while issue was closed.
On 2016/09/12 20:34:57, jbudorick wrote: > On 2016/09/12 20:23:37, nednguyen wrote: > > On 2016/09/12 20:14:54, jbudorick wrote: > > > > > > https://codereview.chromium.org/2326063004/diff/20001/build/android/test_runn... > > > File build/android/test_runner.pydeps (right): > > > > > > > > > https://codereview.chromium.org/2326063004/diff/20001/build/android/test_runn... > > > build/android/test_runner.pydeps:5: > > > > ../../third_party/catapult/common/py_utils/py_utils/cloud_storage_global_lock > > > On 2016/09/10 11:14:50, nednguyen wrote: > > > > We need to figure out what to do with this :-/ > > > > > > I'm not sure this was right. > > > > I think so either, but how should we proceed? :-/ > > Probably let the ANGLE roll go in w/ the change to pydeps. > > Please don't TBR changes to this file, particularly on a Saturday. Sorry, this was blocking a P1 bug against ChromeOS, hence I was being rushy. Note taken. But how should we handle dependencies that aren't python (cloud_storage_global_lock) in this case?
Message was sent while issue was closed.
On 2016/09/12 20:41:17, nednguyen wrote: > On 2016/09/12 20:34:57, jbudorick wrote: > > On 2016/09/12 20:23:37, nednguyen wrote: > > > On 2016/09/12 20:14:54, jbudorick wrote: > > > > > > > > > > https://codereview.chromium.org/2326063004/diff/20001/build/android/test_runn... > > > > File build/android/test_runner.pydeps (right): > > > > > > > > > > > > > > https://codereview.chromium.org/2326063004/diff/20001/build/android/test_runn... > > > > build/android/test_runner.pydeps:5: > > > > > > ../../third_party/catapult/common/py_utils/py_utils/cloud_storage_global_lock > > > > On 2016/09/10 11:14:50, nednguyen wrote: > > > > > We need to figure out what to do with this :-/ > > > > > > > > I'm not sure this was right. > > > > > > I think so either, but how should we proceed? :-/ > > > > Probably let the ANGLE roll go in w/ the change to pydeps. > > > > Please don't TBR changes to this file, particularly on a Saturday. > > Sorry, this was blocking a P1 bug against ChromeOS, hence I was being rushy. > Note taken. But how should we handle dependencies that aren't python > (cloud_storage_global_lock) in this case? As implemented, the pydeps logic *shouldn't* pick up that file. The way to solve this would be revert the lock change, roll that, and then revisit how the pydeps logic handles that file.
Message was sent while issue was closed.
On 2016/09/12 20:43:56, jbudorick wrote: > On 2016/09/12 20:41:17, nednguyen wrote: > > On 2016/09/12 20:34:57, jbudorick wrote: > > > On 2016/09/12 20:23:37, nednguyen wrote: > > > > On 2016/09/12 20:14:54, jbudorick wrote: > > > > > > > > > > > > > > > https://codereview.chromium.org/2326063004/diff/20001/build/android/test_runn... > > > > > File build/android/test_runner.pydeps (right): > > > > > > > > > > > > > > > > > > > > https://codereview.chromium.org/2326063004/diff/20001/build/android/test_runn... > > > > > build/android/test_runner.pydeps:5: > > > > > > > > > ../../third_party/catapult/common/py_utils/py_utils/cloud_storage_global_lock > > > > > On 2016/09/10 11:14:50, nednguyen wrote: > > > > > > We need to figure out what to do with this :-/ > > > > > > > > > > I'm not sure this was right. > > > > > > > > I think so either, but how should we proceed? :-/ > > > > > > Probably let the ANGLE roll go in w/ the change to pydeps. > > > > > > Please don't TBR changes to this file, particularly on a Saturday. > > > > Sorry, this was blocking a P1 bug against ChromeOS, hence I was being rushy. > > Note taken. But how should we handle dependencies that aren't python > > (cloud_storage_global_lock) in this case? > > As implemented, the pydeps logic *shouldn't* pick up that file. > > The way to solve this would be revert the lock change, roll that, and then > revisit how the pydeps logic handles that file. (because, off-hand, I'm not sure what the best way to do so is, and we ought to think about it a bit rather than rush something while this continues to block unrelated CLs) |
