Index: third_party/WebKit/Tools/Scripts/webkitpy/common/net/layouttestresults.py |
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/common/net/layouttestresults.py b/third_party/WebKit/Tools/Scripts/webkitpy/common/net/layouttestresults.py |
index 50a3dd9c9eb1432365c27c1fd0d1e58bcdd049e3..ecb074aee902e0c580a573bc9110dc60a462e5df 100644 |
--- a/third_party/WebKit/Tools/Scripts/webkitpy/common/net/layouttestresults.py |
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/common/net/layouttestresults.py |
@@ -51,23 +51,16 @@ class LayoutTestResult(object): |
return 'PASS' in self.actual_results() |
def did_run_as_expected(self): |
- # TODO(qyearsley): For correctness, this should be: |
- # return not self._result_dict.get('is_unexpected', False) |
- # (Right now for expected results it's not added to the result dict |
- # but in theory it could be present.) |
- return 'is_unexpected' not in self._result_dict |
+ return not self._result_dict.get('is_unexpected', False) |
def is_missing_image(self): |
- # TODO(qyearsley): Change this to: |
- # self._result_dict.get('is_missing_image', False) |
- # The following method should likewise be changed. |
- return 'is_missing_image' in self._result_dict |
+ return self._result_dict.get('is_missing_image', False) |
def is_missing_text(self): |
- return 'is_missing_text' in self._result_dict |
+ return self._result_dict.get('is_missing_text', False) |
def is_missing_audio(self): |
- return 'is_missing_audio' in self._result_dict |
+ return self._result_dict.get('is_missing_audio', False) |
def actual_results(self): |
return self._result_dict['actual'] |