Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2325983002: Replace ASSERT*() with DCHECK*() in modules/websockets (Closed)

Created:
4 years, 3 months ago by hiroshige
Modified:
4 years, 2 months ago
Reviewers:
haraken, yhirano
CC:
chromium-reviews, blink-reviews, tyoshino+watch_chromium.org, yhirano+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace ASSERT*() with DCHECK*() in modules/websockets BUG=645395, 596760 Committed: https://crrev.com/e24cb90223c91a1ffdf8026e9494c851504c9a6b Cr-Commit-Position: refs/heads/master@{#422061}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebase #

Patch Set 3 : Use DCHECK_EQ() etc. #

Patch Set 4 : fix #

Total comments: 2

Patch Set 5 : Remove ALLOW_UNUSED_LOCAL() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -94 lines) Patch
M third_party/WebKit/Source/modules/websockets/DOMWebSocket.cpp View 1 2 3 18 chunks +22 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/modules/websockets/DOMWebSocketTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.cpp View 1 2 17 chunks +35 lines, -34 lines 0 comments Download
M third_party/WebKit/Source/modules/websockets/WebSocketChannel.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.cpp View 1 2 3 4 12 chunks +34 lines, -34 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
hiroshige
PTAL.
4 years, 3 months ago (2016-09-09 09:50:24 UTC) #2
yhirano
A test is failing.
4 years, 3 months ago (2016-09-12 10:30:12 UTC) #3
hiroshige
https://codereview.chromium.org/2325983002/diff/1/third_party/WebKit/Source/modules/websockets/DOMWebSocket.cpp File third_party/WebKit/Source/modules/websockets/DOMWebSocket.cpp (right): https://codereview.chromium.org/2325983002/diff/1/third_party/WebKit/Source/modules/websockets/DOMWebSocket.cpp#newcode513 third_party/WebKit/Source/modules/websockets/DOMWebSocket.cpp:513: DCHECK_LT(utf8.length(), 0u); Oh, this should be DCHECK_GT(). Fixed.
4 years, 2 months ago (2016-09-29 10:48:15 UTC) #4
haraken
LGTM
4 years, 2 months ago (2016-09-29 11:20:35 UTC) #5
yhirano
https://codereview.chromium.org/2325983002/diff/60001/third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.cpp File third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.cpp (right): https://codereview.chromium.org/2325983002/diff/60001/third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.cpp#newcode251 third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.cpp:251: ALLOW_UNUSED_LOCAL(context); Is this needed? Ditto below.
4 years, 2 months ago (2016-09-30 01:50:30 UTC) #6
hiroshige
https://codereview.chromium.org/2325983002/diff/60001/third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.cpp File third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.cpp (right): https://codereview.chromium.org/2325983002/diff/60001/third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.cpp#newcode251 third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.cpp:251: ALLOW_UNUSED_LOCAL(context); On 2016/09/30 01:50:30, yhirano wrote: > Is this ...
4 years, 2 months ago (2016-09-30 06:04:24 UTC) #7
yhirano
lgtm
4 years, 2 months ago (2016-09-30 06:06:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2325983002/80001
4 years, 2 months ago (2016-09-30 07:46:53 UTC) #11
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 2 months ago (2016-09-30 07:52:15 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-09-30 07:54:53 UTC) #14
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/e24cb90223c91a1ffdf8026e9494c851504c9a6b
Cr-Commit-Position: refs/heads/master@{#422061}

Powered by Google App Engine
This is Rietveld 408576698