Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Unified Diff: third_party/WebKit/Source/bindings/scripts/scripts.gni

Issue 2325973002: Remove aggregation of generated binding code. (Closed)
Patch Set: Fix build Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/scripts/scripts.gni
diff --git a/third_party/WebKit/Source/bindings/scripts/scripts.gni b/third_party/WebKit/Source/bindings/scripts/scripts.gni
index 6f9531696db170e9d5794f827e3c5bc69c0732ae..0d69c8948fea669d60d9240ece07f8bea42a06da 100644
--- a/third_party/WebKit/Source/bindings/scripts/scripts.gni
+++ b/third_party/WebKit/Source/bindings/scripts/scripts.gni
@@ -276,30 +276,24 @@ template("idl_impl") {
#
# Parameters:
# sources = a list of source IDL files.
-# component_dir = Name of directory for these files (one word, no slashes).
-# outputs = a list of files to write to.
+# component = a name of directory for these files (one word, no slashes).
+# outputs = a name of file to write to.
template("aggregate_generated_bindings") {
action(target_name) {
script = "//third_party/WebKit/Source/bindings/scripts/aggregate_generated_bindings.py"
- # Write lists of main IDL files to a file, so that the command lines don't
- # exceed OS length limits.
- idl_files_list = "$target_gen_dir/${target_name}_file_list.tmp"
- write_file(idl_files_list, rebase_path(invoker.sources, root_build_dir))
-
- inputs = [ idl_files_list ] + invoker.sources
+ inputs = invoker.sources
outputs = invoker.outputs
+ response_file_contents = rebase_path(inputs, root_build_dir)
args = [
- "--component-directory",
- invoker.component_dir,
- "--input-file",
- rebase_path(idl_files_list, root_build_dir),
+ "--component",
+ invoker.component,
+ "{{response_file_name}}",
]
- if (invoker.is_partial) {
- args += [ "--partial" ]
- }
- args += rebase_path(invoker.outputs, root_build_dir)
+ args += rebase_path(outputs, root_build_dir)
+
+ public_deps = invoker.public_deps
}
}

Powered by Google App Engine
This is Rietveld 408576698