Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Side by Side Diff: third_party/WebKit/Source/bindings/core/v8/BUILD.gn

Issue 2325973002: Remove aggregation of generated binding code. (Closed)
Patch Set: Fix build Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/modules/v8/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//third_party/WebKit/Source/bindings/bindings.gni") 5 import("//third_party/WebKit/Source/bindings/bindings.gni")
6 import("//third_party/WebKit/Source/core/core_idl_files.gni")
7 import("//third_party/WebKit/Source/bindings/scripts/scripts.gni") 6 import("//third_party/WebKit/Source/bindings/scripts/scripts.gni")
8 import("//third_party/WebKit/Source/core/core.gni") 7 import("//third_party/WebKit/Source/core/core.gni")
8 import("//third_party/WebKit/Source/core/core_idl_files.gni")
9 9
10 visibility = [ "//third_party/WebKit/Source/*" ] 10 visibility = [ "//third_party/WebKit/Source/*" ]
11 11
12 generated_core_dictionary_files = [ 12 generated_core_dictionary_files = [
13 "$blink_core_output_dir/animation/AnimationEffectTimingProperties.cpp", 13 "$blink_core_output_dir/animation/AnimationEffectTimingProperties.cpp",
14 "$blink_core_output_dir/animation/AnimationEffectTimingProperties.h", 14 "$blink_core_output_dir/animation/AnimationEffectTimingProperties.h",
15 "$blink_core_output_dir/animation/ComputedTimingProperties.cpp", 15 "$blink_core_output_dir/animation/ComputedTimingProperties.cpp",
16 "$blink_core_output_dir/animation/ComputedTimingProperties.h", 16 "$blink_core_output_dir/animation/ComputedTimingProperties.h",
17 "$blink_core_output_dir/animation/KeyframeEffectOptions.cpp", 17 "$blink_core_output_dir/animation/KeyframeEffectOptions.cpp",
18 "$blink_core_output_dir/animation/KeyframeEffectOptions.h", 18 "$blink_core_output_dir/animation/KeyframeEffectOptions.h",
(...skipping 168 matching lines...) Expand 10 before | Expand all | Expand 10 after
187 187
188 generated_core_testing_dictionary_files = [ 188 generated_core_testing_dictionary_files = [
189 "$blink_core_output_dir/testing/InternalDictionary.cpp", 189 "$blink_core_output_dir/testing/InternalDictionary.cpp",
190 "$blink_core_output_dir/testing/InternalDictionary.h", 190 "$blink_core_output_dir/testing/InternalDictionary.h",
191 "$blink_core_output_dir/testing/InternalDictionaryDerived.cpp", 191 "$blink_core_output_dir/testing/InternalDictionaryDerived.cpp",
192 "$blink_core_output_dir/testing/InternalDictionaryDerived.h", 192 "$blink_core_output_dir/testing/InternalDictionaryDerived.h",
193 "$blink_core_output_dir/testing/InternalDictionaryDerivedDerived.cpp", 193 "$blink_core_output_dir/testing/InternalDictionaryDerivedDerived.cpp",
194 "$blink_core_output_dir/testing/InternalDictionaryDerivedDerived.h", 194 "$blink_core_output_dir/testing/InternalDictionaryDerivedDerived.h",
195 ] 195 ]
196 196
197 if (is_win && is_official_build) { 197 if (is_win) {
198 bindings_core_generated_aggregate_files = 198 # On Windows Official release builds, we try to preserve symbol space.
199 bindings_core_generated_interface_files =
199 [ "$bindings_core_v8_output_dir/V8GeneratedCoreBindings.cpp" ] 200 [ "$bindings_core_v8_output_dir/V8GeneratedCoreBindings.cpp" ]
200 } else { 201 } else {
201 bindings_core_generated_aggregate_files = [ 202 bindings_core_generated_interface_files =
202 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings00.cpp", 203 process_file_template(
203 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings01.cpp", 204 core_definition_idl_files,
204 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings02.cpp", 205 [
205 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings03.cpp", 206 "$bindings_core_v8_output_dir/V8{{source_name_part}}.cpp",
206 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings04.cpp", 207 "$bindings_core_v8_output_dir/V8{{source_name_part}}.h",
207 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings05.cpp", 208 ])
208 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings06.cpp",
209 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings07.cpp",
210 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings08.cpp",
211 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings09.cpp",
212 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings10.cpp",
213 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings11.cpp",
214 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings12.cpp",
215 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings13.cpp",
216 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings14.cpp",
217 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings15.cpp",
218 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings16.cpp",
219 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings17.cpp",
220 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings18.cpp",
221 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings19.cpp",
222 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings20.cpp",
223 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings21.cpp",
224 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings22.cpp",
225 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings23.cpp",
226 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings24.cpp",
227 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings25.cpp",
228 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings26.cpp",
229 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings27.cpp",
230 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings28.cpp",
231 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings29.cpp",
232 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings30.cpp",
233 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings31.cpp",
234 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings32.cpp",
235 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings33.cpp",
236 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings34.cpp",
237 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings35.cpp",
238 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings36.cpp",
239 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings37.cpp",
240 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings38.cpp",
241 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings39.cpp",
242 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings40.cpp",
243 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings41.cpp",
244 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings42.cpp",
245 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings43.cpp",
246 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings44.cpp",
247 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings45.cpp",
248 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings46.cpp",
249 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings47.cpp",
250 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings48.cpp",
251 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings49.cpp",
252 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings50.cpp",
253 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings51.cpp",
254 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings52.cpp",
255 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings53.cpp",
256 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings54.cpp",
257 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings55.cpp",
258 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings56.cpp",
259 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings57.cpp",
260 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings58.cpp",
261 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings59.cpp",
262 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings60.cpp",
263 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings61.cpp",
264 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings62.cpp",
265 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings63.cpp",
266 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings64.cpp",
267 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings65.cpp",
268 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings66.cpp",
269 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings67.cpp",
270 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings68.cpp",
271 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings69.cpp",
272 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings70.cpp",
273 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings71.cpp",
274 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings72.cpp",
275 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings73.cpp",
276 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings74.cpp",
277 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings75.cpp",
278 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings76.cpp",
279 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings77.cpp",
280 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings78.cpp",
281 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings79.cpp",
282 ]
283 } 209 }
284 210
285 group("bindings_core_v8_generated") { 211 group("bindings_core_v8_generated") {
286 public_deps = [ 212 public_deps = [
287 ":bindings_core_impl_generated", 213 ":bindings_core_impl_generated",
288 ":bindings_core_v8_generated_aggregate",
289 ":bindings_core_v8_generated_individual",
290 ] 214 ]
291 } 215 if (is_win) {
292 216 public_deps += [ ":generate_bindings_core_v8_all_interfaces" ]
293 aggregate_generated_bindings("bindings_core_v8_generated_aggregate") { 217 } else {
294 sources = core_definition_idl_files 218 public_deps += [ ":generate_bindings_core_v8_interfaces" ]
295 component_dir = "core" 219 }
296 is_partial = false
297 outputs = bindings_core_generated_aggregate_files
298 } 220 }
299 221
300 # IDL file lists; see: http://www.chromium.org/developers/web-idl-interfaces 222 # IDL file lists; see: http://www.chromium.org/developers/web-idl-interfaces
301 # Interface IDL files: generate individual bindings (includes testing) 223 # Interface IDL files: generate individual bindings (includes testing)
302 idl_compiler("bindings_core_v8_generated_individual") { 224 idl_compiler("generate_bindings_core_v8_interfaces") {
303 sources = core_definition_idl_files + core_testing_definition_idl_files + 225 sources = core_definition_idl_files + core_testing_definition_idl_files +
304 generated_webcore_testing_idl_files 226 generated_webcore_testing_idl_files
305 output_dir = bindings_core_v8_output_dir 227 output_dir = bindings_core_v8_output_dir
306 output_name_suffix = "" 228 output_name_suffix = ""
307 target_component = "core" 229 target_component = "core"
308 } 230 }
309 231
232 aggregate_generated_bindings("generate_bindings_core_v8_all_interfaces") {
233 sources = core_definition_idl_files
234 outputs = [
235 "$bindings_core_v8_output_dir/V8GeneratedCoreBindings.cpp",
236 ]
237 component = "core"
238 public_deps = [
239 ":generate_bindings_core_v8_interfaces",
240 ]
241 }
242
310 idl_impl("bindings_core_impl_generated") { 243 idl_impl("bindings_core_impl_generated") {
311 sources = core_dictionary_idl_files + core_testing_dictionary_idl_files 244 sources = core_dictionary_idl_files + core_testing_dictionary_idl_files
312 outputs = 245 outputs =
313 bindings_core_generated_union_type_files + 246 bindings_core_generated_union_type_files +
314 generated_core_dictionary_files + generated_core_testing_dictionary_files 247 generated_core_dictionary_files + generated_core_testing_dictionary_files
315 output_dir = bindings_core_v8_output_dir 248 output_dir = bindings_core_v8_output_dir
316 target_component = "core" 249 target_component = "core"
317 } 250 }
318 251
319 # Compile the non-test sources generated above. 252 # Compile the non-test sources generated above.
320 blink_core_sources("bindings_core_impl") { 253 blink_core_sources("bindings_core_impl") {
321 sources = 254 sources =
322 bindings_core_generated_union_type_files + 255 bindings_core_generated_union_type_files +
323 generated_core_dictionary_files + bindings_core_generated_aggregate_files 256 generated_core_dictionary_files + bindings_core_generated_interface_files
324 257
325 deps = [ 258 deps = [
326 ":bindings_core_impl_generated", 259 ":bindings_core_v8_generated",
327 ":bindings_core_v8_generated_aggregate",
328 ] 260 ]
329 } 261 }
330 262
331 # Compile the test sources generated above. This test target doesn't count 263 # Compile the test sources generated above. This test target doesn't count
332 # as part of the "core" component so shouldn't use the blink_core_sources for 264 # as part of the "core" component so shouldn't use the blink_core_sources for
333 # linking on Windows. 265 # linking on Windows.
334 source_set("testing") { 266 source_set("testing") {
335 sources = generated_core_testing_dictionary_files 267 sources = generated_core_testing_dictionary_files
336 268
337 configs -= core_config_remove 269 configs -= core_config_remove
338 configs += [ 270 configs += [
339 "//third_party/WebKit/Source:inside_blink", 271 "//third_party/WebKit/Source:inside_blink",
340 "//third_party/WebKit/Source:config", 272 "//third_party/WebKit/Source:config",
341 ] 273 ]
342 274
343 deps = [ 275 deps = [
344 ":bindings_core_impl_generated", 276 ":bindings_core_impl_generated",
345 "//skia", 277 "//skia",
346 "//third_party/WebKit/Source/wtf", 278 "//third_party/WebKit/Source/wtf",
347 "//v8", 279 "//v8",
348 ] 280 ]
349 } 281 }
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/modules/v8/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698