Add options and a browser-action popup.

Add options and a browser-action popup.

Add an options page with a blacklist, an option to disable the extension
in embedded content, and a whitelist to override that option. Add a popup
to easily add/remove the current page from the blacklist. Add a feedback
link that pre-fills an email. Update the build script with the new files.

Options page, popup, and email text are placeholders, pending design support.

BUG=639639, 639645
R=ojan@chromium.org

Committed: https://chromium.googlesource.com/chromium/extensions-by-google/6cfc8a0b8ad0e6d5485912816371ac07eced8259

[Pam (message me for reviews), 2016-09-15 18:59:26]

Description was changed from

==========
Add options and a browser-action popup.

Add an options page with a blacklist, an option to disable the extension
in embedded content, and a whitelist to override that option. Add a popup
to easily add/remove the current page from the blacklist. Add a feedback
link that pre-fills an email. Update the build script with the new files.

Options page, popup, and email text are placeholders, pending design support.

BUG=639639, 639645
==========

to

==========
Add options and a browser-action popup.

Add an options page with a blacklist, an option to disable the extension
in embedded content, and a whitelist to override that option. Add a popup
to easily add/remove the current page from the blacklist. Add a feedback
link that pre-fills an email. Update the build script with the new files.

Options page, popup, and email text are placeholders, pending design support.

BUG=639639, 639645
==========

[Pam (message me for reviews), 2016-09-15 18:59:26]

pam@chromium.org changed reviewers:
+ ojan@chromium.org

[Pam (message me for reviews), 2016-09-15 19:00:07]

Hi, Ojan! Please take a look. Thanks!

As before, UI and strings are placeholders.

[ojan, 2016-09-15 19:07:15]

lgtm

https://codereview.chromium.org/2325963003/diff/60001/go-back-with-backspace/...
File go-back-with-backspace/content_script.js (right):

https://codereview.chromium.org/2325963003/diff/60001/go-back-with-backspace/...
go-back-with-backspace/content_script.js:62: // Return true if the option to
diable the extension in applets is enabled, and
typo: diable

https://codereview.chromium.org/2325963003/diff/60001/go-back-with-backspace/...
File go-back-with-backspace/pages/installed.js (right):

https://codereview.chromium.org/2325963003/diff/60001/go-back-with-backspace/...
go-back-with-backspace/pages/installed.js:8: var all =
document.getElementsByTagName('*');
document.querySelectorAll('[i18n]') should be faster and get you just the
elements you actually need to update.

It doesn't really matter in practice since this page is small.

https://codereview.chromium.org/2325963003/diff/60001/go-back-with-backspace/...
File go-back-with-backspace/pages/options.js (right):

https://codereview.chromium.org/2325963003/diff/60001/go-back-with-backspace/...
go-back-with-backspace/pages/options.js:8: var all =
document.getElementsByTagName('*');
ditto

[Pam (message me for reviews), 2016-09-16 16:35:13]

Thanks for your careful review! I'm only surprised my inexperienced JS doesn't
need more tweaking. :)

https://codereview.chromium.org/2325963003/diff/60001/go-back-with-backspace/...
File go-back-with-backspace/pages/options.js (right):

https://codereview.chromium.org/2325963003/diff/60001/go-back-with-backspace/...
go-back-with-backspace/pages/options.js:8: var all =
document.getElementsByTagName('*');
On 2016/09/15 19:07:15, ojan wrote:
> ditto

Done -- and moved into common.js.

[Pam (message me for reviews), 2016-09-16 16:36:21]

Description was changed from

==========
Add options and a browser-action popup.

Add an options page with a blacklist, an option to disable the extension
in embedded content, and a whitelist to override that option. Add a popup
to easily add/remove the current page from the blacklist. Add a feedback
link that pre-fills an email. Update the build script with the new files.

Options page, popup, and email text are placeholders, pending design support.

BUG=639639, 639645
==========

to

==========
Add options and a browser-action popup.

Add an options page with a blacklist, an option to disable the extension
in embedded content, and a whitelist to override that option. Add a popup
to easily add/remove the current page from the blacklist. Add a feedback
link that pre-fills an email. Update the build script with the new files.

Options page, popup, and email text are placeholders, pending design support.

BUG=639639, 639645
R=ojan@chromium.org

Committed:
https://chromium.googlesource.com/chromium/extensions-by-google/6cfc8a0b8ad0e...
==========

[Pam (message me for reviews), 2016-09-16 16:36:23]

Committed patchset #5 (id:80001) manually as
6cfc8a0b8ad0e6d5485912816371ac07eced8259 (presubmit successful).