Async/await catch prediction for "the synchronous case"

src/isolate.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_ISOLATE_H_
 #define V8_ISOLATE_H_
 
 #include <memory>
 #include <queue>
 
@@ skipping 655 matching lines @@
 
   // This method is called by the api after operations that may throw
   // exceptions.  If an exception was thrown and not handled by an external
   // handler the exception is scheduled to be rethrown when we return to running
   // JavaScript code.  If an exception is scheduled true is returned.
   bool OptionalRescheduleException(bool is_bottom_call);
 
   // Push and pop a promise and the current try-catch handler.
   void PushPromise(Handle<JSObject> promise);
   void PopPromise();
   Handle<Object> GetPromiseOnStackOnThrow();

[adamk, 2016/09/09 19:13:44]

Please give this a comment while you're changing what it does.

[Dan Ehrenberg, 2016/09/10 01:58:03]

Done

[jgruber, 2016/09/12 10:27:31]

I think Adam meant a comment on GetPromiseOnStackOnThrow. I also believe a
comment would be nice, especially since the method does not return the top-most
promise anymore (which is kind of implied by the method name).

[Dan Ehrenberg, 2016/09/12 22:12:11]

Oops, gave a comment on that too. It's still returning a Promise that's on the
stack!

+  bool PromiseHasUserDefinedRejectHandler(Handle<Object> promise);
 
   class ExceptionScope {
    public:
     // Scope currently can only be used for regular exceptions,
     // not termination exception.
     inline explicit ExceptionScope(Isolate* isolate);
     inline ~ExceptionScope();
 
    private:
     Isolate* isolate_;
@@ skipping 986 matching lines @@
 
   EmbeddedVector<char, 128> filename_;
   FILE* file_;
   int scope_depth_;
 };
 
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_ISOLATE_H_