Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Unified Diff: chrome/installer/util/browser_distribution.h

Issue 23258005: Give SxS distribution its own registration GUIDs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove magic key combo from browser_options_handler.cc Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/util/browser_distribution.h
diff --git a/chrome/installer/util/browser_distribution.h b/chrome/installer/util/browser_distribution.h
index b308c04fecddd8223de6ef11c97ae9dcd7f031a3..f1ec82c0db2a4224c4b3b8b74372872a2dfa14a3 100644
--- a/chrome/installer/util/browser_distribution.h
+++ b/chrome/installer/util/browser_distribution.h
@@ -89,6 +89,14 @@ class BrowserDistribution {
// should be suffixed in all scenarios.
virtual string16 GetBaseAppId();
+ // Returns the Browser ProgId prefix (e.g. ChromeHTML, ChromiumHTM, etc...).
+ // The full id is of the form |prefix||suffix| where suffix is a 26-digit
+ // alpha-numeric identifier.
gab 2013/09/06 18:40:08 |suffix| is actually a '.' followed by a 26-charac
zturner 2013/09/06 20:53:16 Done.
+ virtual string16 GetBrowserProgIdPrefix();
+
+ // Returns the Browser ProgId description.
+ virtual string16 GetBrowserProgIdDesc();
+
virtual string16 GetInstallSubDir();
virtual string16 GetPublisherName();
@@ -117,8 +125,20 @@ class BrowserDistribution {
virtual string16 GetVersionKey();
+ // Returns true if setting the default browser is a supported operation.
grt (UTC plus 2) 2013/09/06 02:53:39 it seems that uninstall is the only real use of th
gab 2013/09/06 18:40:08 Hmmm, I'm not sure about that, we usually put NOTR
grt (UTC plus 2) 2013/09/09 18:39:15 I see your point. I find these two methods (IsFooS
+ virtual bool IsSetAsDefaultSupported();
+
+ // Returns true if this distribution can be set as the default browser.
+ // Note that this is not the same as IsSetAsDefaultSupported, which returns
+ // true if the browser can EVER be set as default. It is possible for the
+ // operation to be supported but currently disabled (for example due to
+ // policy).
virtual bool CanSetAsDefault();
+ // Forces CanSetAsDefault() to return true. For distributions where
+ // IsSetAsDefaultSupported() returns false, this function is a no-op.
+ virtual void DebugEnableSetAsDefault();
+
virtual bool CanCreateDesktopShortcuts();
virtual bool GetChromeChannel(string16* channel);
@@ -126,7 +146,11 @@ class BrowserDistribution {
// Returns true if this distribution includes a DelegateExecute verb handler,
// and provides the CommandExecuteImpl class UUID if |handler_class_uuid| is
// non-NULL.
- virtual bool GetCommandExecuteImplClsid(string16* handler_class_uuid);
+ virtual bool GetCommandExecuteImplClsidString(string16* handler_class_uuid);
+
+#if defined(OS_WIN)
+ virtual bool GetCommandExecuteImplClsid(CLSID* handler_class_uuid);
+#endif
// Returns true if this distribution uses app_host.exe to run platform apps.
virtual bool AppHostIsSupported();

Powered by Google App Engine
This is Rietveld 408576698