Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(872)

Unified Diff: chrome/installer/util/browser_distribution.h

Issue 23258005: Give SxS distribution its own registration GUIDs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed IsSetAsDefaultSupported() and GetCommandExecuteImplClsid(), and other minor cleanup. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/util/browser_distribution.h
diff --git a/chrome/installer/util/browser_distribution.h b/chrome/installer/util/browser_distribution.h
index b308c04fecddd8223de6ef11c97ae9dcd7f031a3..0296ef0a0de9f7a77a6f4f0eb543747e958fd6f9 100644
--- a/chrome/installer/util/browser_distribution.h
+++ b/chrome/installer/util/browser_distribution.h
@@ -89,6 +89,18 @@ class BrowserDistribution {
// should be suffixed in all scenarios.
virtual string16 GetBaseAppId();
+ // Returns the Browser ProgId prefix (e.g. ChromeHTML, ChromiumHTM, etc...).
+ // The full id is of the form |prefix|.|suffix| and is limited to a maximum
+ // length of 39 characters including null-terminator. See
+ // http://msdn.microsoft.com/library/aa911706.aspx for details. We define
+ // |suffix| as a fixed-length 26-character alphanumeric identifier, therefore
+ // the return value of this function should have a maximum length of
+ // 39 - 1(null-term) - 26(|suffix|) - 1(dot separator) = 11 characters.
+ virtual string16 GetBrowserProgIdPrefix();
+
+ // Returns the Browser ProgId description.
+ virtual string16 GetBrowserProgIdDesc();
+
virtual string16 GetInstallSubDir();
virtual string16 GetPublisherName();
@@ -117,8 +129,13 @@ class BrowserDistribution {
virtual string16 GetVersionKey();
+ // Returns true if this distribution can be set as the default browser.
virtual bool CanSetAsDefault();
+ // Forces CanSetAsDefault() to return true. For distributions where
+ // IsSetAsDefaultSupported() returns false, this function is a no-op.
+ virtual void DebugEnableSetAsDefault();
+
virtual bool CanCreateDesktopShortcuts();
virtual bool GetChromeChannel(string16* channel);
@@ -126,7 +143,7 @@ class BrowserDistribution {
// Returns true if this distribution includes a DelegateExecute verb handler,
// and provides the CommandExecuteImpl class UUID if |handler_class_uuid| is
// non-NULL.
- virtual bool GetCommandExecuteImplClsid(string16* handler_class_uuid);
+ virtual bool GetCommandExecuteImplClsidString(string16* handler_class_uuid);
grt (UTC plus 2) 2013/09/09 18:39:15 please revert this to its original name to reduce
// Returns true if this distribution uses app_host.exe to run platform apps.
virtual bool AppHostIsSupported();

Powered by Google App Engine
This is Rietveld 408576698