Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 2325763003: Add tinted static UI resource cache (Closed)

Created:
4 years, 3 months ago by mdjones
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Add tinted static UI resource cache This change adds a method to the ResourceManager that allows users to create a tinted version of a static resource. These resources are cached until the layout changes. In practice, this new functionality is used to tint the border resource and close button in the tab switcher. BUG=641517 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2293573002 Cr-Commit-Position: refs/heads/master@{#417482} (cherry picked from commit 4adb368fd86135a5f3f888895640b776395356b8) Committed: https://chromium.googlesource.com/chromium/src/+/fedd423e345eba095248fde9f384595630aa7341

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -40 lines) Patch
M cc/resources/ui_resource_bitmap.h View 2 chunks +6 lines, -0 lines 0 comments Download
M cc/resources/ui_resource_bitmap.cc View 2 chunks +9 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/Layout.java View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/android/compositor/layer/tab_layer.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/android/compositor/layer/tab_layer.cc View 6 chunks +4 lines, -33 lines 0 comments Download
M chrome/browser/android/compositor/scene_layer/tab_list_scene_layer.h View 2 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/android/compositor/scene_layer/tab_list_scene_layer.cc View 4 chunks +11 lines, -2 lines 0 comments Download
M ui/android/java/src/org/chromium/ui/resources/ResourceManager.java View 2 chunks +9 lines, -0 lines 0 comments Download
M ui/android/resources/resource_manager.h View 2 chunks +11 lines, -0 lines 0 comments Download
M ui/android/resources/resource_manager_impl.h View 4 chunks +10 lines, -0 lines 0 comments Download
M ui/android/resources/resource_manager_impl.cc View 2 chunks +75 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
mdjones
4 years, 3 months ago (2016-09-09 17:14:10 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fedd423e345eba095248fde9f384595630aa7341.

Powered by Google App Engine
This is Rietveld 408576698