Fix bug in AOT compiler where we would propogate a result type for instances calls where the target…

runtime/vm/intermediate_language.cc

Index: runtime/vm/intermediate_language.cc
diff --git a/runtime/vm/intermediate_language.cc b/runtime/vm/intermediate_language.cc
index 20b876e0257912444917573344e6ea6782e93a80..0307fa2077e7eec9f96ad85d0445a15848850866 100644
--- a/runtime/vm/intermediate_language.cc
+++ b/runtime/vm/intermediate_language.cc
@@ -3188,6 +3188,8 @@ void InstanceCallInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
 
 
 bool PolymorphicInstanceCallInstr::HasSingleRecognizedTarget() const {
+  if (FLAG_precompiled_mode && with_checks()) return false;
+
   return ic_data().HasOneTarget() &&
       (MethodRecognizer::RecognizeKind(
           Function::Handle(ic_data().GetTargetAt(0))) !=
@@ -3196,6 +3198,8 @@ bool PolymorphicInstanceCallInstr::HasSingleRecognizedTarget() const {
 
 
 bool PolymorphicInstanceCallInstr::HasOnlyDispatcherTargets() const {
+  if (FLAG_precompiled_mode && with_checks()) return false;

[Florian Schneider, 2016/09/08 20:53:53]

This function seems only used when finding inlining candidates. Maybe it should
be moved as is to ICData::HasOnlyDispatcherTargets() instead? Then it would not
depend on with_checks and FLAG_precompiled_mode.

[rmacnak, 2016/09/08 21:33:39]

Done.

+
   for (intptr_t i = 0; i < ic_data().NumberOfChecks(); ++i) {
     const Function& target = Function::Handle(ic_data().GetTargetAt(i));
     if (!target.IsNoSuchMethodDispatcher() &&