Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Side by Side Diff: runtime/vm/flow_graph_inliner.cc

Issue 2325753002: Fix bug in AOT compiler where we would propogate a result type for instances calls where the target… (Closed)
Patch Set: review Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | runtime/vm/intermediate_language.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/flow_graph_inliner.h" 5 #include "vm/flow_graph_inliner.h"
6 6
7 #include "vm/aot_optimizer.h" 7 #include "vm/aot_optimizer.h"
8 #include "vm/block_scheduler.h" 8 #include "vm/block_scheduler.h"
9 #include "vm/branch_optimizer.h" 9 #include "vm/branch_optimizer.h"
10 #include "vm/compiler.h" 10 #include "vm/compiler.h"
(...skipping 344 matching lines...) Expand 10 before | Expand all | Expand 10 after
355 block_it.Advance()) { 355 block_it.Advance()) {
356 for (ForwardInstructionIterator it(block_it.Current()); 356 for (ForwardInstructionIterator it(block_it.Current());
357 !it.Done(); 357 !it.Done();
358 it.Advance()) { 358 it.Advance()) {
359 Instruction* current = it.Current(); 359 Instruction* current = it.Current();
360 if (current->IsPolymorphicInstanceCall()) { 360 if (current->IsPolymorphicInstanceCall()) {
361 PolymorphicInstanceCallInstr* instance_call = 361 PolymorphicInstanceCallInstr* instance_call =
362 current->AsPolymorphicInstanceCall(); 362 current->AsPolymorphicInstanceCall();
363 if (!inline_only_recognized_methods || 363 if (!inline_only_recognized_methods ||
364 instance_call->HasSingleRecognizedTarget() || 364 instance_call->HasSingleRecognizedTarget() ||
365 instance_call->HasOnlyDispatcherTargets()) { 365 instance_call->ic_data().HasOnlyDispatcherTargets()) {
366 instance_calls_.Add(InstanceCallInfo(instance_call, graph)); 366 instance_calls_.Add(InstanceCallInfo(instance_call, graph));
367 } else { 367 } else {
368 // Method not inlined because inlining too deep and method 368 // Method not inlined because inlining too deep and method
369 // not recognized. 369 // not recognized.
370 if (FLAG_print_inlining_tree) { 370 if (FLAG_print_inlining_tree) {
371 const Function* caller = &graph->function(); 371 const Function* caller = &graph->function();
372 const Function* target = 372 const Function* target =
373 &Function::ZoneHandle( 373 &Function::ZoneHandle(
374 instance_call->ic_data().GetTargetAt(0)); 374 instance_call->ic_data().GetTargetAt(0));
375 inlined_info->Add(InlinedInfo( 375 inlined_info->Add(InlinedInfo(
(...skipping 3402 matching lines...) Expand 10 before | Expand all | Expand 10 after
3778 return true; 3778 return true;
3779 } 3779 }
3780 3780
3781 default: 3781 default:
3782 return false; 3782 return false;
3783 } 3783 }
3784 } 3784 }
3785 3785
3786 3786
3787 } // namespace dart 3787 } // namespace dart
OLDNEW
« no previous file with comments | « no previous file | runtime/vm/intermediate_language.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698