Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Side by Side Diff: net/quic/chromium/quic_chromium_client_session_test.cc

Issue 2325733004: Makes QuicChromiumPacketWriter use the delegate for interacting with the connection. (Closed)
Patch Set: Nits fixed. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/quic/chromium/quic_chromium_client_session.h" 5 #include "net/quic/chromium/quic_chromium_client_session.h"
6 6
7 #include "base/base64.h" 7 #include "base/base64.h"
8 #include "base/files/file_path.h" 8 #include "base/files/file_path.h"
9 #include "base/memory/ptr_util.h" 9 #include "base/memory/ptr_util.h"
10 #include "base/rand_util.h" 10 #include "base/rand_util.h"
(...skipping 111 matching lines...) Expand 10 before | Expand all | Expand 10 after
122 "CONNECTION_UNKNOWN", base::TimeTicks::Now(), &push_promise_index_, 122 "CONNECTION_UNKNOWN", base::TimeTicks::Now(), &push_promise_index_,
123 base::ThreadTaskRunnerHandle::Get().get(), 123 base::ThreadTaskRunnerHandle::Get().get(),
124 /*socket_performance_watcher=*/nullptr, &net_log_)); 124 /*socket_performance_watcher=*/nullptr, &net_log_));
125 125
126 scoped_refptr<X509Certificate> cert( 126 scoped_refptr<X509Certificate> cert(
127 ImportCertFromFile(GetTestCertsDirectory(), "spdy_pooling.pem")); 127 ImportCertFromFile(GetTestCertsDirectory(), "spdy_pooling.pem"));
128 verify_details_.cert_verify_result.verified_cert = cert; 128 verify_details_.cert_verify_result.verified_cert = cert;
129 verify_details_.cert_verify_result.is_issued_by_known_root = true; 129 verify_details_.cert_verify_result.is_issued_by_known_root = true;
130 session_->Initialize(); 130 session_->Initialize();
131 session_->StartReading(); 131 session_->StartReading();
132 writer->Initialize(session_.get(), connection); 132 writer->set_delegate(session_.get());
133 } 133 }
134 134
135 void TearDown() override { 135 void TearDown() override {
136 session_->CloseSessionOnError(ERR_ABORTED, QUIC_INTERNAL_ERROR); 136 session_->CloseSessionOnError(ERR_ABORTED, QUIC_INTERNAL_ERROR);
137 } 137 }
138 138
139 void CompleteCryptoHandshake() { 139 void CompleteCryptoHandshake() {
140 ASSERT_THAT(session_->CryptoConnect(false, callback_.callback()), IsOk()); 140 ASSERT_THAT(session_->CryptoConnect(false, callback_.callback()), IsOk());
141 } 141 }
142 142
143 QuicChromiumPacketWriter* CreateQuicChromiumPacketWriter( 143 QuicChromiumPacketWriter* CreateQuicChromiumPacketWriter(
144 DatagramClientSocket* socket, 144 DatagramClientSocket* socket,
145 QuicChromiumClientSession* session) const { 145 QuicChromiumClientSession* session) const {
146 std::unique_ptr<QuicChromiumPacketWriter> writer( 146 std::unique_ptr<QuicChromiumPacketWriter> writer(
147 new QuicChromiumPacketWriter(socket)); 147 new QuicChromiumPacketWriter(socket));
148 writer->Initialize(session, session->connection()); 148 writer->set_delegate(session);
149 return writer.release(); 149 return writer.release();
150 } 150 }
151 151
152 QuicCryptoClientConfig crypto_config_; 152 QuicCryptoClientConfig crypto_config_;
153 TestNetLog net_log_; 153 TestNetLog net_log_;
154 BoundTestNetLog bound_net_log_; 154 BoundTestNetLog bound_net_log_;
155 MockClientSocketFactory socket_factory_; 155 MockClientSocketFactory socket_factory_;
156 std::unique_ptr<MockRead> default_read_; 156 std::unique_ptr<MockRead> default_read_;
157 std::unique_ptr<SequencedSocketData> socket_data_; 157 std::unique_ptr<SequencedSocketData> socket_data_;
158 MockClock clock_; 158 MockClock clock_;
(...skipping 441 matching lines...) Expand 10 before | Expand all | Expand 10 after
600 session_->connection()->SendPing(); 600 session_->connection()->SendPing();
601 EXPECT_FALSE(session_->connection()->connected()); 601 EXPECT_FALSE(session_->connection()->connected());
602 602
603 EXPECT_TRUE(socket_data.AllReadDataConsumed()); 603 EXPECT_TRUE(socket_data.AllReadDataConsumed());
604 EXPECT_TRUE(socket_data.AllWriteDataConsumed()); 604 EXPECT_TRUE(socket_data.AllWriteDataConsumed());
605 } 605 }
606 606
607 } // namespace 607 } // namespace
608 } // namespace test 608 } // namespace test
609 } // namespace net 609 } // namespace net
OLDNEW
« no previous file with comments | « net/quic/chromium/quic_chromium_client_session.cc ('k') | net/quic/chromium/quic_chromium_packet_writer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698