Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1045)

Issue 2325733003: Document SVGImage with a class-level comment (Closed)

Created:
4 years, 3 months ago by pdr.
Modified:
4 years, 3 months ago
CC:
fs, blink-reviews, chromium-reviews, krit, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Document SVGImage with a class-level comment The way SVGImage works is surprising. For example, it is not obvious that we don't use Skia but instead re-use the existing paint pipeline in Blink, nor that SVGImage contains a detached Page. This patch adds some high-level documentation to make these quirks more obvious. Some minor line-wrapping has also been cleaned up. BUG=644913 NOTRY=true Committed: https://crrev.com/6bfa5aace01353b25e5e468e759f48df3e010f50 Cr-Commit-Position: refs/heads/master@{#417665}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase with clean tree this time #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -15 lines) Patch
M third_party/WebKit/Source/core/svg/graphics/SVGImage.h View 1 4 chunks +35 lines, -15 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
pdr.
This class was badly in need of some high-level documentation. Please nitpick.
4 years, 3 months ago (2016-09-09 00:38:31 UTC) #2
davve
Describes the quirkiness of SVGImage well. Thanks! LGTM.
4 years, 3 months ago (2016-09-09 08:29:09 UTC) #3
fs
lgtm
4 years, 3 months ago (2016-09-09 08:39:46 UTC) #4
f(malita)
lgtm
4 years, 3 months ago (2016-09-09 13:57:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2325733003/1
4 years, 3 months ago (2016-09-09 19:03:57 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/256726)
4 years, 3 months ago (2016-09-09 19:10:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2325733003/40001
4 years, 3 months ago (2016-09-09 19:18:27 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-09 19:23:19 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 19:26:28 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6bfa5aace01353b25e5e468e759f48df3e010f50
Cr-Commit-Position: refs/heads/master@{#417665}

Powered by Google App Engine
This is Rietveld 408576698