Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 2325733002: media: Remove CreateMediaRendererFactory() (Closed)

Created:
4 years, 3 months ago by xhwang
Modified:
4 years, 3 months ago
Reviewers:
jam, DaleCurtis
CC:
alokp, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media: Remove CreateMediaRendererFactory() Now ChromeCast has switched to use mojo Renderer, nobody is using this path any more. BUG=571155 TEST=No functionality change Committed: https://crrev.com/77548d0202f93049c26d52a6ec9644e29f9e680e Cr-Commit-Position: refs/heads/master@{#417515}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -24 lines) Patch
M content/public/renderer/content_renderer_client.h View 1 chunk +0 lines, -6 lines 0 comments Download
M content/public/renderer/content_renderer_client.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 chunk +5 lines, -10 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
xhwang
A small cleanup CL. jam: Please review as content/ OWNER. dalecurtis: Please review from media's ...
4 years, 3 months ago (2016-09-08 21:27:55 UTC) #6
DaleCurtis
lgtm
4 years, 3 months ago (2016-09-08 21:29:01 UTC) #7
jam
lgtm
4 years, 3 months ago (2016-09-09 00:05:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2325733002/1
4 years, 3 months ago (2016-09-09 06:23:01 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-09 06:26:40 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 06:28:21 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/77548d0202f93049c26d52a6ec9644e29f9e680e
Cr-Commit-Position: refs/heads/master@{#417515}

Powered by Google App Engine
This is Rietveld 408576698