Deliver Menu key event after sending context menu event

Deliver Menu key event after sending context menu event

BUG=168845
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171830

[anish.p, 2014-04-10 09:02:50]

This behavior is similar to Firefox now.

[Nate Chapin, 2014-04-11 15:58:46]

On 2014/04/10 09:02:50, anish.p wrote:
> This behavior is similar to Firefox now.

I'll defer to adamk, I don't think I'm qualified to review this.

[adamk, 2014-04-14 17:03:53]

...and unfortunately I have to defer as well, to tkent, to whom I send all my
questions about handling input events.

[tkent, 2014-04-15 05:04:54]

Looks a reasonable change.
Please add a test.

[anish.p, 2014-04-15 11:40:26]

On 2014/04/15 05:04:54, tkent wrote:
> Looks a reasonable change.
> Please add a test.

I have updated ManualTests/keyboard-menukey-event.html as per DOMContextMenu
test.
Please take a look.

[tkent, 2014-04-16 01:29:35]

We should not add new manual test.
Please make a layout test or a unit test.

[anish.p, 2014-04-16 04:58:32]

Added a layout test and removed earlier manual test patch. 
Please take a look.

[tkent, 2014-04-16 05:18:40]

https://codereview.chromium.org/232573002/diff/70001/LayoutTests/fast/events/...
File LayoutTests/fast/events/keydown-menu-key-expected.txt (right):

https://codereview.chromium.org/232573002/diff/70001/LayoutTests/fast/events/...
LayoutTests/fast/events/keydown-menu-key-expected.txt:1: This test verifies the
keycode sent when we press Menu key. This test applies only to Linux and
Windows.
Please add this to LayoutTests/NeverFixTests for Mac.

https://codereview.chromium.org/232573002/diff/70001/LayoutTests/fast/events/...
LayoutTests/fast/events/keydown-menu-key-expected.txt:5:
Type=keyup,keyCode=93,ctrlKey=false,shiftKey=false,altKey=false,metaKey=false
We should verify the order of key events and contextmenu event, right?

[anish.p, 2014-04-16 06:50:25]

Please have a look. I made changes as per review comments.

https://codereview.chromium.org/232573002/diff/70001/LayoutTests/fast/events/...
File LayoutTests/fast/events/keydown-menu-key-expected.txt (right):

https://codereview.chromium.org/232573002/diff/70001/LayoutTests/fast/events/...
LayoutTests/fast/events/keydown-menu-key-expected.txt:1: This test verifies the
keycode sent when we press Menu key. This test applies only to Linux and
Windows.
On 2014/04/16 05:18:40, tkent wrote:
> Please add this to LayoutTests/NeverFixTests for Mac.

Done.

https://codereview.chromium.org/232573002/diff/70001/LayoutTests/fast/events/...
LayoutTests/fast/events/keydown-menu-key-expected.txt:5:
Type=keyup,keyCode=93,ctrlKey=false,shiftKey=false,altKey=false,metaKey=false
On 2014/04/16 05:18:40, tkent wrote:
> We should verify the order of key events and contextmenu event, right?

Done.

[tkent, 2014-04-16 08:38:21]

The test failed on windows.  Please investigate it.

https://storage.googleapis.com/chromium-layout-test-archives/win_blink_rel/39...

[anish.p, 2014-04-16 09:03:43]

On Windows, KeyUp triggers context menu. In my opinion, thats why test failed.
I do not have Windows build to check. I have created separate test expectations
for Windows and Linux.
I am not familiar with tests. Could you have a look and see if this is alright?

[tkent, 2014-04-17 01:49:27]

lgtm

[commit-bot: I haz the power, 2014-04-17 01:49:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/anish.p@samsung.com/232573002/110001

[commit-bot: I haz the power, 2014-04-17 02:53:43]

Change committed as 171830