Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 2325723003: Cleanup Ash Metro mode. (Closed)

Created:
4 years, 3 months ago by rjkroege
Modified:
4 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup Ash Metro mode. Remove an unecessary switch exposed during ash::DisplayManager refactoring. BUG=581462 Committed: https://crrev.com/cb3445dfeb795ebb74173977929dc29c7319880c Cr-Commit-Position: refs/heads/master@{#417474}

Patch Set 1 #

Patch Set 2 : cleanup #

Total comments: 2

Patch Set 3 : review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -25 lines) Patch
M ash/common/ash_switches.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M ash/common/ash_switches.cc View 1 1 chunk +0 lines, -7 lines 0 comments Download
M ash/test/ash_test_base.cc View 1 1 chunk +0 lines, -5 lines 0 comments Download
M ash/test/test_suite.cc View 1 2 2 chunks +3 lines, -10 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
rjkroege
Per IM. ptal.
4 years, 3 months ago (2016-09-08 22:24:21 UTC) #6
sky
https://codereview.chromium.org/2325723003/diff/20001/ash/test/test_suite.cc File ash/test/test_suite.cc (left): https://codereview.chromium.org/2325723003/diff/20001/ash/test/test_suite.cc#oldcode40 ash/test/test_suite.cc:40: // Although Ash officially is only supported for users ...
4 years, 3 months ago (2016-09-08 23:45:36 UTC) #7
rjkroege
ptal https://codereview.chromium.org/2325723003/diff/20001/ash/test/test_suite.cc File ash/test/test_suite.cc (left): https://codereview.chromium.org/2325723003/diff/20001/ash/test/test_suite.cc#oldcode40 ash/test/test_suite.cc:40: // Although Ash officially is only supported for ...
4 years, 3 months ago (2016-09-09 00:04:21 UTC) #8
sky
LGTM
4 years, 3 months ago (2016-09-09 00:25:47 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2325723003/40001
4 years, 3 months ago (2016-09-09 00:29:12 UTC) #11
commit-bot: I haz the power
Exceeded global retry quota
4 years, 3 months ago (2016-09-09 00:47:48 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2325723003/40001
4 years, 3 months ago (2016-09-09 01:24:46 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-09 01:28:20 UTC) #16
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 01:32:06 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/cb3445dfeb795ebb74173977929dc29c7319880c
Cr-Commit-Position: refs/heads/master@{#417474}

Powered by Google App Engine
This is Rietveld 408576698