Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Unified Diff: components/crash/content/app/crashpad.cc

Issue 2325713002: Manual crash uploads for mac and win (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/crash/content/app/crashpad.h ('k') | components/crash/core/browser/crashes_ui_util.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/crash/content/app/crashpad.cc
diff --git a/components/crash/content/app/crashpad.cc b/components/crash/content/app/crashpad.cc
index 6a8e3ac88278900f71cf54b46ab916c2107adb1d..3d76644cc0e7f5262986a160ccbd0c446423d5be 100644
--- a/components/crash/content/app/crashpad.cc
+++ b/components/crash/content/app/crashpad.cc
@@ -278,7 +278,9 @@ void GetReports(std::vector<Report>* reports) {
report.local_id = pending_report.uuid.ToString();
report.capture_time = pending_report.creation_time;
report.upload_time = 0;
- report.state = ReportUploadState::Pending;
+ report.state = pending_report.upload_explicitly_requested
+ ? ReportUploadState::Pending_UserRequested
+ : report.state = ReportUploadState::Pending;
reports->push_back(report);
}
@@ -288,6 +290,14 @@ void GetReports(std::vector<Report>* reports) {
});
}
+void RequestSingleCrashUpload(const std::string& local_id) {
+ if (!g_database)
+ return;
+ crashpad::UUID uuid;
+ uuid.InitializeFromString(local_id);
+ g_database->RequestUpload(uuid);
+}
+
} // namespace crash_reporter
#if defined(OS_WIN)
@@ -318,6 +328,12 @@ void __declspec(dllexport) __cdecl ClearCrashKeyValueImpl(const wchar_t* key) {
crash_reporter::ClearCrashKey(base::UTF16ToUTF8(key));
}
+// This helper is invoked by code in chrome.dll to request a single crash report
+// upload. See CrashUploadListCrashpad.
+void __declspec(dllexport)
+ RequestSingleCrashUploadImpl(const std::string& local_id) {
+ crash_reporter::RequestSingleCrashUpload(local_id);
+}
} // extern "C"
#endif // OS_WIN
« no previous file with comments | « components/crash/content/app/crashpad.h ('k') | components/crash/core/browser/crashes_ui_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698