Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 2325713002: Manual crash uploads for mac and win (Closed)

Created:
4 years, 3 months ago by jwd
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Manual crash uploads for mac and win Adding functionally for requesting upload for a crash report from about:crashes page and propagating the request to crashpad. BUG=620762 Review-Url: https://codereview.chromium.org/2268783002 Cr-Commit-Position: refs/heads/master@{#416945} (cherry picked from commit f132d5d5801871170f5d87aabb9bad3339c9c022) Committed: https://chromium.googlesource.com/chromium/src/+/e299643c1a472625ebb0ed91ee824c5b0f6b256f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+186 lines, -35 lines) Patch
M chrome/browser/crash_upload_list/crash_upload_list_crashpad.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/crash_upload_list/crash_upload_list_crashpad.cc View 4 chunks +30 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/crashes_ui.cc View 6 chunks +48 lines, -1 line 0 comments Download
M components/crash/content/app/crashpad.h View 2 chunks +5 lines, -1 line 0 comments Download
M components/crash/content/app/crashpad.cc View 3 chunks +17 lines, -1 line 0 comments Download
M components/crash/core/browser/crashes_ui_util.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/crash/core/browser/crashes_ui_util.cc View 3 chunks +5 lines, -0 lines 0 comments Download
M components/crash/core/browser/resources/crashes.html View 1 chunk +5 lines, -5 lines 0 comments Download
M components/crash/core/browser/resources/crashes.js View 4 chunks +41 lines, -24 lines 0 comments Download
M components/crash_strings.grdp View 2 chunks +6 lines, -1 line 0 comments Download
M components/upload_list/upload_list.h View 3 chunks +9 lines, -2 lines 0 comments Download
M components/upload_list/upload_list.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/webui/crashes_ui.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
jwd
4 years, 3 months ago (2016-09-08 17:53:34 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e299643c1a472625ebb0ed91ee824c5b0f6b256f.

Powered by Google App Engine
This is Rietveld 408576698