Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(813)

Issue 2325673002: removed const from ASTVarDeclaration::fName to avoid a Chromium build failure (Closed)

Created:
4 years, 3 months ago by ethannicholas
Modified:
4 years, 3 months ago
Reviewers:
dogben
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

removed const from ASTVarDeclaration::fName to avoid a Chromium build failure GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2325673002 Committed: https://skia.googlesource.com/skia/+/f86809730ef3392db0fdbe78d3cd3a2df5696fd4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/sksl/ast/SkSLASTVarDeclaration.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
ethannicholas
4 years, 3 months ago (2016-09-08 15:21:33 UTC) #3
dogben
lgtm
4 years, 3 months ago (2016-09-08 15:30:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2325673002/1
4 years, 3 months ago (2016-09-08 15:54:35 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 16:19:54 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/f86809730ef3392db0fdbe78d3cd3a2df5696fd4

Powered by Google App Engine
This is Rietveld 408576698