Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 2325643004: Remove HttpNetworkTransaction::DescribeState. (Closed)

Created:
4 years, 3 months ago by Randy Smith (Not in Mondays)
Modified:
4 years, 3 months ago
Reviewers:
mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove HttpNetworkTransaction::DescribeState. HttpNetworkTransaction::DescribeState was a debugging routine used to print out ascii names for state values, but it had bit-rotted. Removing under the presumption that no-one is using it. BUG=None R=mmenke@chromium.org Committed: https://crrev.com/a358d746efcfc7e66ef56ec787661c2cf945c06b Cr-Commit-Position: refs/heads/master@{#417604}

Patch Set 1 #

Patch Set 2 : Remove default handler to force compiler error on future updates. #

Patch Set 3 : Removed describe state function. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -37 lines) Patch
M net/http/http_network_transaction.h View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M net/http/http_network_transaction.cc View 1 2 1 chunk +0 lines, -34 lines 0 comments Download

Messages

Total messages: 19 (12 generated)
Randy Smith (Not in Mondays)
Matt, quick review? I'm open to deleting this code as well, but I don't want ...
4 years, 3 months ago (2016-09-08 22:16:32 UTC) #3
mmenke
On 2016/09/08 22:16:32, Randy Smith - Not in Fridays wrote: > Matt, quick review? I'm ...
4 years, 3 months ago (2016-09-08 22:24:37 UTC) #4
Randy Smith (Not in Mondays)
On 2016/09/08 22:24:37, mmenke wrote: > On 2016/09/08 22:16:32, Randy Smith - Not in Fridays ...
4 years, 3 months ago (2016-09-09 15:16:46 UTC) #10
mmenke
On 2016/09/09 15:16:46, Randy Smith - Not in Fridays wrote: > On 2016/09/08 22:24:37, mmenke ...
4 years, 3 months ago (2016-09-09 15:25:19 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2325643004/40001
4 years, 3 months ago (2016-09-09 16:42:03 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-09 16:47:01 UTC) #17
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 16:48:22 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a358d746efcfc7e66ef56ec787661c2cf945c06b
Cr-Commit-Position: refs/heads/master@{#417604}

Powered by Google App Engine
This is Rietveld 408576698