Disables user manager actions only if there is at least one regular profile and they're all locked.

Previously, User manager actions were being disabled if no regular (aka custodian) profiles existed (b/c it's not possible to have a supervised profile on its own).

Since it's possible for child profiles to exist on their own, this CL changes the behavior so that user manager actions are disabled only if there is at least one regular profile and that all regular profiles are locked.

BUG=640885
Committed: https://crrev.com/2ed22bdcbf5985dbfe4c2e5cafa12b5ef851f77e
Cr-Commit-Position: refs/heads/master@{#417576}

[Moe, 2016-09-08 14:06:17]

The CQ bit was checked by mahmadi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-08 14:06:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Moe, 2016-09-08 14:10:43]

Description was changed from

==========
Disables user manager actions only if there is at least one regular profile and
they're all locked.

BUG=640885
==========

to

==========
Previously, User manager actions were being disabled if no regular (aka
custodian) profiles existed (b/c it's not possible to have a supervised profile
on its own).

Since it's possible for child profiles to exist on their own, this CL changes
the behavior so that user manager actions are disabled only if there is at least
one regular profile and that all regular profiles are locked.

BUG=640885
==========

[Moe, 2016-09-08 14:10:43]

mahmadi@chromium.org changed reviewers:
+ anthonyvd@chromium.org

[Moe, 2016-09-08 14:11:21]

Hi Anthony, Please take a look at this CL.

[anthonyvd, 2016-09-08 14:27:54]

lgtm % small nit

https://codereview.chromium.org/2325643003/diff/1/chrome/browser/profiles/pro...
File chrome/browser/profiles/profiles_state.h (right):

https://codereview.chromium.org/2325643003/diff/1/chrome/browser/profiles/pro...
chrome/browser/profiles/profiles_state.h:109: bool AreAllProfilesLocked();
nit: can this be renamed to something more descriptive of what it does after
this change?

[commit-bot: I haz the power, 2016-09-08 14:52:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 14:52:54]

Dry run: This issue passed the CQ dry run.

[Moe, 2016-09-08 17:36:15]

The CQ bit was checked by mahmadi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-08 17:36:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Moe, 2016-09-08 17:37:03]

Thanks!

https://codereview.chromium.org/2325643003/diff/1/chrome/browser/profiles/pro...
File chrome/browser/profiles/profiles_state.h (right):

https://codereview.chromium.org/2325643003/diff/1/chrome/browser/profiles/pro...
chrome/browser/profiles/profiles_state.h:109: bool AreAllProfilesLocked();
On 2016/09/08 14:27:54, anthonyvd wrote:
> nit: can this be renamed to something more descriptive of what it does after
> this change?

Done.

[commit-bot: I haz the power, 2016-09-08 18:41:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 18:41:14]

Dry run: This issue passed the CQ dry run.

[Moe, 2016-09-08 22:13:39]

The CQ bit was checked by mahmadi@chromium.org

[Moe, 2016-09-08 22:13:39]

The patchset sent to the CQ was uploaded after l-g-t-m from
anthonyvd@chromium.org
Link to the patchset: https://codereview.chromium.org/2325643003/#ps20001
(title: "Addressed comment")

[commit-bot: I haz the power, 2016-09-08 22:14:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 22:19:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 22:19:33]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Moe, 2016-09-08 22:27:06]

mahmadi@chromium.org changed reviewers:
+ rogerta@chromium.org

[Moe, 2016-09-08 22:27:06]

rogerta@ please review c/b/ui/webui/signin/

[Roger Tawa OOO till Jul 10th, 2016-09-09 13:35:53]

lgtm

[Moe, 2016-09-09 13:47:06]

The CQ bit was checked by mahmadi@chromium.org

[commit-bot: I haz the power, 2016-09-09 13:47:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 13:50:34]

Description was changed from

==========
Previously, User manager actions were being disabled if no regular (aka
custodian) profiles existed (b/c it's not possible to have a supervised profile
on its own).

Since it's possible for child profiles to exist on their own, this CL changes
the behavior so that user manager actions are disabled only if there is at least
one regular profile and that all regular profiles are locked.

BUG=640885
==========

to

==========
Previously, User manager actions were being disabled if no regular (aka
custodian) profiles existed (b/c it's not possible to have a supervised profile
on its own).

Since it's possible for child profiles to exist on their own, this CL changes
the behavior so that user manager actions are disabled only if there is at least
one regular profile and that all regular profiles are locked.

BUG=640885
==========

[commit-bot: I haz the power, 2016-09-09 13:50:34]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-09 13:51:57]

Description was changed from

==========
Previously, User manager actions were being disabled if no regular (aka
custodian) profiles existed (b/c it's not possible to have a supervised profile
on its own).

Since it's possible for child profiles to exist on their own, this CL changes
the behavior so that user manager actions are disabled only if there is at least
one regular profile and that all regular profiles are locked.

BUG=640885
==========

to

==========
Previously, User manager actions were being disabled if no regular (aka
custodian) profiles existed (b/c it's not possible to have a supervised profile
on its own).

Since it's possible for child profiles to exist on their own, this CL changes
the behavior so that user manager actions are disabled only if there is at least
one regular profile and that all regular profiles are locked.

BUG=640885

Committed: https://crrev.com/2ed22bdcbf5985dbfe4c2e5cafa12b5ef851f77e
Cr-Commit-Position: refs/heads/master@{#417576}
==========

[commit-bot: I haz the power, 2016-09-09 13:51:58]

Patchset 2 (id:??) landed as
https://crrev.com/2ed22bdcbf5985dbfe4c2e5cafa12b5ef851f77e
Cr-Commit-Position: refs/heads/master@{#417576}