Pull OpenSSL at 263283 to get new GN build file.

Pull OpenSSL at 263283 to get new GN build file.

Adds a reference to it in the root gn build file.

R=rsleevi@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263334

[brettw, 2014-04-10 17:45:52]

https://codereview.chromium.org/232563008/diff/10003/tools/gn/secondary/third...
File tools/gn/secondary/third_party/openssl/BUILD.gn (right):

https://codereview.chromium.org/232563008/diff/10003/tools/gn/secondary/third...
tools/gn/secondary/third_party/openssl/BUILD.gn:752: cflags += [
GYP would disable all warnings in this case, but it turns out there's only this
one, so I disabled it and kept the default warnings.

[Ryan Sleevi, 2014-04-10 18:03:00]

openssl.gypi is auto-generated whenever we roll OpenSSL, because we're trying to
keep things sync'd both with AOSP and upstream. My fear is this is going to
require manual maintenance.

Does GN support include files? Would it be possible to have
import_from_android.sh spit out the requisite GN directives as well?

[brettw, 2014-04-10 18:11:24]

On 2014/04/10 18:03:00, Ryan Sleevi wrote:
> openssl.gypi is auto-generated whenever we roll OpenSSL, because we're trying
to
> keep things sync'd both with AOSP and upstream. My fear is this is going to
> require manual maintenance.
> 
> Does GN support include files? Would it be possible to have
> import_from_android.sh spit out the requisite GN directives as well?

Lemme look into this.

[brettw, 2014-04-10 21:46:36]

Okay, Skia needed something similar so I wrote a way to import the .gypi. PTAL

[Ryan Sleevi, 2014-04-10 22:01:46]

lgtm

https://codereview.chromium.org/232563008/diff/30001/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/232563008/diff/30001/BUILD.gn#newcode51
BUILD.gn:51: if (is_posix) {  # TODO(brettw) should be use_openssl
Any reason for not doing this? We're working on bringing up the Mac port atm. I
don't want to slow GN down, just curious.

https://codereview.chromium.org/232563008/diff/30001/tools/gn/secondary/third...
File tools/gn/secondary/third_party/openssl/BUILD.gn (right):

https://codereview.chromium.org/232563008/diff/30001/tools/gn/secondary/third...
tools/gn/secondary/third_party/openssl/BUILD.gn:22: # The list of Skia files is
kept in skia_gn_files.gypi. Read it.
comment update?

[brettw, 2014-04-11 17:47:31]

https://codereview.chromium.org/232563008/diff/30001/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/232563008/diff/30001/BUILD.gn#newcode51
BUILD.gn:51: if (is_posix) {  # TODO(brettw) should be use_openssl
On 2014/04/10 22:01:46, Ryan Sleevi wrote:
> Any reason for not doing this? We're working on bringing up the Mac port atm.
I
> don't want to slow GN down, just curious.

This flag doesn't exist yet. I was anticipating doing this when we figure out
all the NSS stuff.

[brettw, 2014-04-11 17:57:32]

Forked off BUILD file change to upstream OpenSSL deps in
https://codereview.chromium.org/234833005/

[brettw, 2014-04-11 20:23:37]

Committed patchset #4 manually as r263334 (presubmit successful).