Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1821)

Unified Diff: Source/core/testing/Internals.h

Issue 232563003: API functions returning Promises should not throw exceptions. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/tests/results/V8TestObject.cpp ('k') | Source/core/testing/Internals.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/testing/Internals.h
diff --git a/Source/core/testing/Internals.h b/Source/core/testing/Internals.h
index efd6f512e6d9f6f3c40dccff2332993f8cb20293..a199a38a4d254f410ca140f0a0f66f5ca382b567 100644
--- a/Source/core/testing/Internals.h
+++ b/Source/core/testing/Internals.h
@@ -300,7 +300,10 @@ public:
ScriptPromise createResolvedPromise(ScriptState*, ScriptValue);
ScriptPromise createRejectedPromise(ScriptState*, ScriptValue);
- ScriptPromise addOneToPromise(ExecutionContext*, ScriptPromise);
+ ScriptPromise addOneToPromise(ScriptState*, ScriptPromise);
+ ScriptPromise promiseCheck(ScriptState*, long, bool, const Dictionary&, const String&, const Vector<String>&, ExceptionState&);
+ ScriptPromise promiseCheckWithoutExceptionState(ScriptState*, const Dictionary&, const String&, const Vector<String>&);
+ ScriptPromise promiseCheckRange(ScriptState*, long);
void trace(Visitor*);
« no previous file with comments | « Source/bindings/tests/results/V8TestObject.cpp ('k') | Source/core/testing/Internals.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698