Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Unified Diff: Source/bindings/scripts/v8_interface.py

Issue 232563003: API functions returning Promises should not throw exceptions. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/core/v8/V8BindingMacros.h ('k') | Source/bindings/scripts/v8_methods.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/scripts/v8_interface.py
diff --git a/Source/bindings/scripts/v8_interface.py b/Source/bindings/scripts/v8_interface.py
index 9d38fcac7d120dff631493488c643d78b901da69..974bb045d012891c1b8fa15987524d684eac52bb 100644
--- a/Source/bindings/scripts/v8_interface.py
+++ b/Source/bindings/scripts/v8_interface.py
@@ -852,7 +852,7 @@ def sort_and_groupby(l, key=None):
# [Constructor]
def constructor_context(interface, constructor):
- arguments_need_try_catch = any(v8_methods.argument_needs_try_catch(argument)
+ arguments_need_try_catch = any(v8_methods.argument_needs_try_catch(argument, return_promise=False)
for argument in constructor.arguments)
# [RaisesException=Constructor]
« no previous file with comments | « Source/bindings/core/v8/V8BindingMacros.h ('k') | Source/bindings/scripts/v8_methods.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698