Source/bindings/scripts/v8_interface.py - Issue 232563003: API functions returning Promises should not throw exceptions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/v8_interface.py

Issue 232563003: API functions returning Promises should not throw exceptions. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/scripts/v8_interface.py

diff --git a/Source/bindings/scripts/v8_interface.py b/Source/bindings/scripts/v8_interface.py

index 21c2747c151ce50920308bb99cf2cf54539d53ab..872c35fb04273313df11680072a68feda2cc3955 100644

--- a/Source/bindings/scripts/v8_interface.py

+++ b/Source/bindings/scripts/v8_interface.py

@@ -850,7 +850,7 @@ def sort_and_groupby(l, key=None):

# [Constructor]

def constructor_context(interface, constructor):

- arguments_need_try_catch = any(v8_methods.argument_needs_try_catch(argument)

+ arguments_need_try_catch = any(v8_methods.argument_needs_try_catch(argument, async=False)

haraken 2014/08/01 17:04:24 async => return_promise ? The same comment for ot

yhirano 2014/08/04 01:42:08 Done.

for argument in constructor.arguments)

# [RaisesException=Constructor]

« Source/bindings/core/v8/V8BindingMacros.h ('K') | « Source/bindings/core/v8/V8BindingMacros.h ('k') | Source/bindings/scripts/v8_methods.py » ('j') | no next file with comments »