Source/core/testing/Internals.h - Issue 232563003: API functions returning Promises should not throw exceptions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/testing/Internals.h

Issue 232563003: API functions returning Promises should not throw exceptions. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/testing/Internals.h

diff --git a/Source/core/testing/Internals.h b/Source/core/testing/Internals.h

index ed565809118044608b0ab56660a0366b8ab45dd2..a2e961d3dd1dbd7d4cfe8bfcdacc535161563551 100644

--- a/Source/core/testing/Internals.h

+++ b/Source/core/testing/Internals.h

@@ -300,7 +300,10 @@ public:

ScriptPromise createResolvedPromise(ScriptState*, ScriptValue);

ScriptPromise createRejectedPromise(ScriptState*, ScriptValue);

- ScriptPromise addOneToPromise(ExecutionContext*, ScriptPromise);

+ ScriptPromise addOneToPromise(ScriptState*, ScriptPromise);

+ ScriptPromise promiseCheck(ScriptState*, long, bool, const Dictionary&, const String&, const Vector<String>&, ExceptionState&);

+ ScriptPromise promiseCheckWithoutExceptionState(ScriptState*, const Dictionary&, const String&, const Vector<String>&);

+ ScriptPromise promiseCheckRange(ScriptState*, long);

void trace(Visitor*);

« Source/bindings/templates/methods.cpp ('K') | « Source/bindings/tests/results/V8TestObject.cpp ('k') | Source/core/testing/Internals.cpp » ('j') | no next file with comments »