Source/bindings/tests/idls/TestObject.idl - Issue 232563003: API functions returning Promises should not throw exceptions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/idls/TestObject.idl

Issue 232563003: API functions returning Promises should not throw exceptions. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/tests/idls/TestObject.idl

diff --git a/Source/bindings/tests/idls/TestObject.idl b/Source/bindings/tests/idls/TestObject.idl

index bbe9ff6e46072102dbd510a599645157107d654a..00994e9895c392112c2f20e6dc35813c9a7d3f62 100644

--- a/Source/bindings/tests/idls/TestObject.idl

+++ b/Source/bindings/tests/idls/TestObject.idl

@@ -366,7 +366,8 @@ interface TestObject {

// Exceptional types

Dictionary dictionaryMethod();

NodeFilter nodeFilterMethod();

- Promise promiseMethod();

+ Promise promiseMethod(long arg1, Dictionary arg2, DOMString arg3, DOMString... variadic);

+ Promise promiseMethodWithoutExceptionState(Dictionary arg1);

SerializedScriptValue serializedScriptValueMethod();

XPathNSResolver xPathNSResolverMethod();

void voidMethodDictionaryArg(Dictionary dictionaryArg);

« Source/bindings/templates/methods.cpp ('K') | « Source/bindings/templates/methods.cpp ('k') | Source/bindings/tests/results/V8TestObject.cpp » ('j') | no next file with comments »